I found out that we are marking imap delete twice once before we go to the server and once after, so it unsets during the deletion, and when we do undo it sets back the delete flag. so we will have to decide which one we do not need

This case statement was responsible for setting the delete flag back on undo. There is no need to send delete/move notification to front-end because we do not select any message on undo/redo. Also for undo/redo where delete model is not moving to trash the dstFolder will be null. david, please review.

changing summary

the code you removed did much more than just send a notification to the front end - it updated the database as well. Are you sure that's not needed either? I think it also made it so that when you delete a message in the imap delete model, the next message gets selected. Does that still work after your change?

OK, I take that last part back, since we shouldn't be trying to change the selection on removing the deleted flag. But we want to reflect the change to the db.

I have checked deleting all msgs and undo delete still works. This will prevent from setting the delete flag again when we are trying to subtract it.

great, r=bienvenu

Isn't this bug dup of bug 59694?

Karen, Well not really, it does not toggle

But the undo/redo part is fixed, may be you can change the summary on that bug to make it toggle (only).

sr=mscott

fix checked in.

Verified on WinNT 08-15-06-trunk build. Great! Now, Undo/Redo is working on IMAP Mark as deleted mode!

And, I already updated bug 59694 for toggle only.