Closed
Bug 946639
Opened 11 years ago
Closed 11 years ago
enable AVX2 on Linux if supported (libvpx)
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: j, Assigned: rillian)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Current toolchain on build servers does not support AVX2. Once its supported Linux builds should use AVX2.
|
Reporter | |
Updated•11 years ago
|
Summary: enable AVX2 on Linux is supported (libvpx) → enable AVX2 on Linux if supported (libvpx)
|
||
Comment 1•11 years ago
|
||
Looks like a valid bug to me, so confirming :)
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
Assignee | |
Comment 2•11 years ago
|
||
According to glandium on irc, the issue is the binutils version on our build machines; gcc supports the instructions, but the assembler does not.
Depends on: 938510
|
|
Assignee | |
Comment 3•11 years ago
|
||
Hmm. This patch actually passes try. Maybe this is a different issue from libyuv because libvpx uses intrinsics for this instead of inline assembly?
Assignee: nobody → giles
Attachment #8360512 -
Flags: review?(cpearce)
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8360512 [details] [diff] [review]
Enable AVX2
Review of attachment 8360512 [details] [diff] [review]:
-----------------------------------------------------------------
I wonder if we can enable this on Windows too?
Attachment #8360512 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Chris Pearce (:cpearce) from comment #5)
> I wonder if we can enable this on Windows too?
As soon as we move to VS2012. :)
https://hg.mozilla.org/integration/mozilla-inbound/rev/684a92697548
|
|
Reporter | |
Comment 7•11 years ago
|
||
While enabling it for builds, would be also good to remove the special case from update.py to disable it.
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•