Open
Bug 946645
Opened 11 years ago
Updated 2 years ago
Replace all users of CrashReports.jsm with Services.crashes and delete CrashReports.jsm
Categories
(Toolkit :: Crash Reporting, defect, P3)
Toolkit
Crash Reporting
Tracking
()
NEW
People
(Reporter: gps, Unassigned)
References
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
CrashReports.jsm is old and janky (literally - it uses synchronous I/O). Users of CrashReports.jsm should be refactored to use Services.crashes from bug 875562 and CrashReports.jsm should be deleted once no in-tree consumers remain.
Reporter | ||
Comment 1•11 years ago
|
||
I started down this road for a few minutes as part of working on the
blocking bug. But this work is not blocking getting that bug landed, so
I quickly abandoned it.
about:crashes could use a lot of love. For one, the page title says
"submitted crash reports" even though it mixes pending and submitted. We
should throw a few section headers in there to differentiate between
submitted and pending. I started this work but stopped short because it
wasn't critical to the other bug.
We'll also need a delete API on Services.crashes. I'll add that in the
blocking bug - it's trivial enough to implement.
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment 2•11 years ago
|
||
The "pending crashes are hard to distinguish" thing is bug 512479.
Updated•11 years ago
|
Priority: -- → P3
Reporter | ||
Comment 3•11 years ago
|
||
The requisite parts of bug 875562 have landed and this bug should be unblocked from implementation.
I'm putting this in the mentored bugs pool if anyone wants to have a go at it. There's no docs on MDN yet. You'll be using the new code at https://hg.mozilla.org/mozilla-central/file/default/toolkit/components/crashes/CrashManager.jsm to read crash data. See the existing patch (which no longer works) for inspiration.
Whiteboard: [mentor=gps][lang=js]
Reporter | ||
Updated•10 years ago
|
Assignee: gps → nobody
Status: ASSIGNED → NEW
Assignee | ||
Updated•10 years ago
|
Mentor: gps
Whiteboard: [mentor=gps][lang=js] → [lang=js]
Can I take up this bug? I have mozilla-central downloaded, I am new and interested to work on it.
Reporter | ||
Comment 5•10 years ago
|
||
Yes, you can have it.
I'm on a business trip to Europe until September 2. If you need more information, I encourage you to ping bsmedberg, as I may not respond to bug updates promptly.
Assignee: nobody → n.n.nachiketh
Status: NEW → ASSIGNED
Updated•6 years ago
|
Comment 6•3 years ago
|
||
Looks like there are still 2 users of CrashReports.jsm.
Assignee: n.n.nachiketh → nobody
Mentor: gps
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•