Michał Budzyński (:michalbe) Assignee
	Description • 11 years ago

Contacts app should use separate sheets for every view, and use window.open instead of build-in navigation module.

	Michał Budzyński (:michalbe) Assignee
	Comment 1 • 11 years ago

I've merged sheets support provided by bug #961800 on bubble-tea branch yesterday and found some regressions & parts of the app that are not working (mostly because I couldn't test them before because of the one-popup-per-app limitation). I'm working now on fixing all of them [1], I should finally have patch ready to r? early next week. In the meantime, parts of my WIP patch can be checked in my contacts-haida branch [2]. 

Because of the change in architecture, most of the test are failing so far. I'll finish fixing them just after I'll fix all the regressions.

[1] Etherpad with things that don't work as expected https://etherpad.mozilla.org/contacts-haida-regressions
[2] https://github.com/michalbe/gaia/tree/contacts-haida

	Michał Budzyński (:michalbe) Assignee
	Comment 2 • 10 years ago

According to things decided on Contacts workweek last week, solving this bug will be separated into two steps described in the Etherpad document [1]. First part (separating views, but keeping current navigation pattern) is Bug #952490, second step is Bug #952563. 

[1] https://etherpad.mozilla.org/contacts-haida

	Michał Budzyński (:michalbe) Assignee
	Comment 3 • 10 years ago

Work in progress - last week I've separated HTML of 'add new contact' form and implement first state of the iframe based navigation [1]. Instead of using Haida pattern supported in system I created separate iframe for each view and load view's html document inside (just for the 'form' view for now). The iframe after that behaves like 'section' elements before, there is no difference for end user.

[1] https://github.com/michalbe/gaia/commit/fe342416637414292003e21f00f841794cad0ad9

	Francisco Jordano [:arcturus] [:francisco]
	Comment 4 • 10 years ago

Nice, is the whole work in this branch?

https://github.com/michalbe/gaia/compare/module-separation-contacts-haida

	Francisco Jordano [:arcturus] [:francisco]
	Comment 5 • 10 years ago

Some comments, with the current WIP, just to take into account before any review:

- We won't need all css and js now in form.js
- Remove dead code (I know you'll in a cleaning step ;P)

And that's all I've seen \o/

Looking forward for the next iterations!

Thanks a lot Michal!

	Francisco Jordano [:arcturus] [:francisco]
	Comment 6 • 10 years ago

Btw, just saw the visual refresh for contacts starting to land:

https://bugzilla.mozilla.org/show_bug.cgi?id=966224

The sooner we rebase the better.

Thanks!

	Michał Budzyński (:michalbe) Assignee
	Comment 7 • 10 years ago

About your comment - in this branch I focus on navigation, I'll merge with the rest later this week.

	Michał Budzyński (:michalbe) Assignee
	Comment 8 • 10 years ago

'Rest' of the contact app (all the views etc.).

	Michał Budzyński (:michalbe) Assignee
	Comment 9 • 10 years ago

WIP update: I've pushed next part of the navigation system in michalbe/gaia:module-separation-contacts-haida. What it basically do is creating a new navigaitonStack object that is used in all the child views (not the main view) inside the iframes. Every time any of it's methods is called it sends postMsg to the parent window with request to the navigation action (haida-navigation-shim-receiver.js in main view). Rest of the logic is unchanged, so it behaves as before.

I'm now merging new changes to my branch, finish separating views and complete the navigation-shim with needed actions.

	Francisco Jordano [:arcturus] [:francisco]
	Comment 10 • 10 years ago

Thanks!!

Looking forward for more changes, did you had any problem with iframes created during different imports?

	Michał Budzyński (:michalbe) Assignee
	Comment 11 • 10 years ago

I didn't get to this part so far, I have some mess in settings and trying to resolve it now.

	Michał Budzyński (:michalbe) Assignee
	Comment 12 • 10 years ago

Finally, first WIP patch prepared. Some tests are still failing, but since it's a huge architecture change, I would love :arcturus to start reviewing it while I'll fix them.

	Francisco Jordano [:arcturus] [:francisco]
	Comment 13 • 10 years ago

Comment on attachment 8436912 [details]
[WIP] patch

Also asking for Jose's review here.

	Francisco Jordano [:arcturus] [:francisco]
	Comment 14 • 10 years ago

BTW, just realised, should this patch be attached to a specific bug for the form view?

As I'm seeing this is the meta for whole haida effort, and looks to me as it should be in a separate bug.

	Michał Budzyński (:michalbe) Assignee
	Comment 15 • 10 years ago

Ok, filing a bug now.

	BMO Automation
	Comment 16 • 6 years ago

Firefox OS is not being worked on