Closed Bug 946817 Opened 11 years ago Closed 11 years ago

Startup assertion at mozilla::ThreadStackHelper::GetStack with debug b2g emulator

Categories

(Core :: Gecko Profiler, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: gwagner, Assigned: jchen)

References

Details

Attachments

(1 file, 1 obsolete file)

If this is b2g only then it's probably because we don't register secondary threads on b2g to avoid allocating a pseduostack to lower memory.
Attached patch Don't assert mPseudoStack on B2G (v1) (obsolete) (deleted) — Splinter Review
(In reply to Benoit Girard (:BenWa) from comment #1) > If this is b2g only then it's probably because we don't register secondary > threads on b2g to avoid allocating a pseduostack to lower memory. Thanks; that makes sense. This patch makes us assert having a pseudostack on non-b2g platforms only.
Attachment #8343240 - Flags: review?(bgirard)
Comment on attachment 8343240 [details] [diff] [review] Don't assert mPseudoStack on B2G (v1) Review of attachment 8343240 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/threads/ThreadStackHelper.cpp @@ +155,5 @@ > + /* Normally, provided the profiler is enabled, it would be an error if we > + don't have a pseudostack here (the thread probably forgot to call > + profiler_register_thread). However, on B2G, profiling secondary threads > + may be disabled despite profiler being enabled. This is a limitation of > + the profiler and not an error. */ Not a limitation of profiler. It's an explicit decision to save memory.
Attachment #8343240 - Flags: review?(bgirard) → review+
(In reply to Benoit Girard (:BenWa) from comment #3) > Comment on attachment 8343240 [details] [diff] [review] > Don't assert mPseudoStack on B2G (v1) > > Review of attachment 8343240 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: xpcom/threads/ThreadStackHelper.cpp > @@ +155,5 @@ > > + /* Normally, provided the profiler is enabled, it would be an error if we > > + don't have a pseudostack here (the thread probably forgot to call > > + profiler_register_thread). However, on B2G, profiling secondary threads > > + may be disabled despite profiler being enabled. This is a limitation of > > + the profiler and not an error. */ > > Not a limitation of profiler. It's an explicit decision to save memory. Okay. Changed "limitation" to "by-design"
Attachment #8343240 - Attachment is obsolete: true
Attachment #8343545 - Flags: review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → All
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: