Jesse Ruderman Reporter
	Description • 11 years ago

We're missing some regression-test and fuzzing coverage as a result of this.

(I noticed this while looking at bug 934072, but it was out of date even beofre that.)

	Jesse Ruderman Reporter
	Comment 2 • 11 years ago

Is this patch based on a list of values from one of the CSS specs?

https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-type indicates that we also support some -moz- values, but I'm not sure where to look in the code for the real list.

	David Baron :dbaron:
	Comment 3 • 11 years ago

http://hg.mozilla.org/mozilla-central/file/ae2c044c6418/layout/style/nsCSSProps.cpp#l1234

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 4 • 11 years ago

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #3)
> http://hg.mozilla.org/mozilla-central/file/ae2c044c6418/layout/style/
> nsCSSProps.cpp#l1234

Thanks! I'll rewrite the patch according to this file.
I just wonder if we need to test the Mozilla extensions? And should I add the values with -moz- prefix if the unprefixed counterpart exists?

	David Baron :dbaron:
	Comment 5 • 11 years ago

I think it should include all the values that we support (and no others).

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 6 • 11 years ago

This patch adds all supported values from nsCSSProps.cpp.

	Jesse Ruderman Reporter
	Comment 7 • 11 years ago

Comment on attachment 8344087 [details] [diff] [review]
patch v2

Great!

I think this should go through tryserver on one platform (e.g. to make sure the -moz- aliases serlialize as expected).  Do you have/want tryserver access, or do you want me to push it to try for you?

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 8 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=c5684a2bbc99

	Jesse Ruderman Reporter
	Comment 9 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/298fa4d5c72e

	David Baron :dbaron:
	Comment 10 • 11 years ago

Thanks to both of you for getting this fixed.

	Carsten Book [:Tomcat]
	Comment 11 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/298fa4d5c72e