What with LayerManagerOGL going away and all the churn in layers at the moment, it turns out there is a fair bit of tidying up (minor refactorings) to be done in and around LayerManagerComposite.

Comment on attachment 8344391 [details] [diff] [review] Part 4 - Tidy up interaction with widgets Review of attachment 8344391 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/opengl/GLManager.cpp @@ +55,5 @@ > + if (Compositor::GetBackend() == LAYERS_OPENGL) { > + return new GLManagerCompositor(static_cast<CompositorOGL*>( > + aManager->GetCompositor())); > + } else { > + return nullptr; Style nit on pre-existing code: remove the else since it's after a return statement anyway.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4639c5abea80 https://hg.mozilla.org/integration/mozilla-inbound/rev/99f8ad7561ef https://hg.mozilla.org/integration/mozilla-inbound/rev/7d035322f51d https://hg.mozilla.org/integration/mozilla-inbound/rev/498152aec5b1 https://hg.mozilla.org/integration/mozilla-inbound/rev/6dd0a6cb9ab3

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/45193a6d7994 for extreme displeasure on the part of reftest-ipc

try push: https://tbpl.mozilla.org/?tree=Try&rev=d08bbd03b851

https://hg.mozilla.org/integration/mozilla-inbound/rev/b341049f5f47 https://hg.mozilla.org/integration/mozilla-inbound/rev/c79d9a33dd43 https://hg.mozilla.org/integration/mozilla-inbound/rev/f0f2576c3340 https://hg.mozilla.org/integration/mozilla-inbound/rev/c105bff9ee1d https://hg.mozilla.org/integration/mozilla-inbound/rev/3d9dc352e2cb

https://hg.mozilla.org/mozilla-central/rev/b341049f5f47 https://hg.mozilla.org/mozilla-central/rev/c79d9a33dd43 https://hg.mozilla.org/mozilla-central/rev/f0f2576c3340 https://hg.mozilla.org/mozilla-central/rev/c105bff9ee1d https://hg.mozilla.org/mozilla-central/rev/3d9dc352e2cb