Closed
Bug 947015
Opened 11 years ago
Closed 5 years ago
ConvolverNode does not respect changes to normalize after buffer is set
Categories
(Core :: Web Audio, defect, P3)
Tracking
()
RESOLVED
FIXED
People
(Reporter: karlt, Unassigned, Mentored)
References
Details
(Whiteboard: [spec])
Attachments
(1 file)
|
(deleted),
text/html
|
Details |
Expected: Both buttons should make the same sound as the response buffer is the identity impulse response.
Actual: the convolved oscillator is quieter.
|
||
Comment 1•10 years ago
|
||
The spec is heading in a direction where `normalized` is only read when the buffer is set, so buffers would only be normalized if `normalized` is `true` before setting the buffer. NI to myself so I read the test case, convert it into a proper test, etc.
Flags: needinfo?(padenot)
|
|
||
Comment 3•9 years ago
|
||
Yes, buffers are only normalized when set, so we need to test this.
https://github.com/WebAudio/web-audio-api/issues/122
Flags: needinfo?(padenot)
|
|
||
Updated•9 years ago
|
Assignee: nobody → padenot
|
|
||
Updated•8 years ago
|
Assignee: padenot → nobody
Mentor: padenot
|
||
Comment 4•7 years ago
|
||
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
|
|
||
Comment 5•5 years ago
|
||
We're doing the right thing, per spec. The spec has changed to only take the normalization into account at the time the buffer is set, and it's what we do.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•