Closed Bug 947061 Opened 11 years ago Closed 11 years ago

Strategy for resuming email verification after browser restart

Categories

(Firefox :: Firefox Accounts, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jedp, Unassigned)

References

Details

(Whiteboard: [qa?])

For the FxAccounts.jsm module (bug 909967), if a user shuts down the browser in the middle of the email verification process, we need to do the right thing when the browser is started up again. How should the verification process be started again? Should it: a) be triggered when the browser starts? (This is what it does now, and it seems a bit ungainly) b) be triggered when getSignedInUser returns an unverified identity? (Makes the caller pay for it) c) be placed on some kind of "nice" queue for deferred execution after browser start-up is complete and the dust has settled (is there such a thing?) d) something else?
Whiteboard: [qa?]
Blocks: 949055
(In reply to Jed Parsons (use needinfo, please) [:jedp, :jparsons] from comment #0) > > b) be triggered when getSignedInUser returns an unverified identity? (Makes > the caller pay for it) FWIW, this is actually what FxAccountsManager does with getAccounts. If I am not wrong, we only need the information about a verified account when: 1- we want an assertion 2- we want to show the account details For B2G, in both cases, we use FxAccountsManager.getAccounts that requests the verification status if the account is not yet verified. Take a look at [1] and [2]. [1] https://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/FxAccountsManager.jsm#225 [2] https://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/FxAccountsManager.jsm#245 FxAccountsManager was designed under the assumption that it would be used by all product implementations (b2g, android, desktop) at some point, so we would get this fix for free.
Component: Firefox: Common → FxA
Product: Mozilla Services → Core
Jed, I think I am satisfied with the current behavior of b). We can let the product owners decide otherwise. Are you OK with marking this resolved/works for me?
Blocks: 974096
No longer blocks: 949055, 935245
Flags: needinfo?(jparsons)
(In reply to Sam Penrose from comment #2) > Jed, I think I am satisfied with the current behavior of b). We can let the > product owners decide otherwise. Are you OK with marking this resolved/works > for me? Yes. For the record, in case we revisit this in the future, Brian Warner has a lot of context on this issue, both with the old and the new sync.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(jparsons)
Resolution: --- → WORKSFORME
Product: Core → Firefox
You need to log in before you can comment on or make changes to this bug.