Enable NFC only when ro.moz.nfc.enabled system property is set to "true"

Comment on attachment 8343585 [details] [diff] [review] Enable/Disable NFC according to system property Review of attachment 8343585 [details] [diff] [review]: ----------------------------------------------------------------- Add r=me

Comment on attachment 8343660 [details] [diff] [review] Enable/Disable NFC according to system property Review of attachment 8343660 [details] [diff] [review]: ----------------------------------------------------------------- oh, I already r+ on this so you don't have to send r? to me again.

Made some improvement for this patch 1. Remove defineLazyGetter because libcutils will always be used. 2. Move check NFC_ENABLED before calling XPCOMUtils.generateNSGetFactory.

Backed out for B2G mochitest-3 orange. https://hg.mozilla.org/integration/b2g-inbound/rev/ae8513dfb00f https://tbpl.mozilla.org/php/getParsedLog.php?id=31815826&tree=B2g-Inbound 09:21:55 INFO - 39153 INFO TEST-START | /tests/dom/bindings/test/test_bug707564.html 09:21:55 INFO - ************************************************************ 09:21:55 INFO - * Call to xpconnect wrapped JSObject produced this error: * 09:21:55 INFO - [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)" location: "JS frame :: jar:file:///system/b2g/omni.ja!/components/nsNfc.js :: mozNfc :: line 142" data: no] 09:21:55 INFO - ************************************************************ 09:21:55 INFO - 39154 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/bindings/test/test_bug707564.html | uncaught exception - NS_ERROR_FAILURE: at http://mochi.test:8888/tests/dom/bindings/test/test_bug707564.html:17 09:21:55 INFO - JavaScript error: http://mochi.test:8888/tests/dom/bindings/test/test_bug707564.html, line 17: NS_ERROR_FAILURE: 09:21:55 INFO - 39155 INFO TEST-INFO | MEMORY STAT vsize after test: 117841920 09:21:55 INFO - 39156 INFO TEST-INFO | MEMORY STAT residentFast after test: 63442944 09:21:55 INFO - 39157 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 22978752 09:21:55 INFO - 39158 INFO TEST-END | /tests/dom/bindings/test/test_bug707564.html | finished in 1300ms

Re-pushed with a fix, was green locally: https://hg.mozilla.org/integration/b2g-inbound/rev/c05f64192ce2

Hi Michael, Could you help merge the pull request for mozilla-b2g/device-mako, thanks !

triage: ~3MB memory saving. 1.3+ to benefit tarako and the changes are small

The pull request for mozilla-b2g / device-mako is not merged yet, could you help merge it ? Thanks

Merged. For future reference, you can set checkin-needed on bugs to get the pull requests merged.

Ying, please add ro.moz.nfc.enabled=false on fugu and tarako.

(In reply to James Zhang from comment #16) > Ying, please add ro.moz.nfc.enabled=false on fugu and tarako. James, did that happen? It's not in my image from last week.

(In reply to Fabrice Desré [:fabrice] from comment #17) > (In reply to James Zhang from comment #16) > > Ying, please add ro.moz.nfc.enabled=false on fugu and tarako. > > James, did that happen? It's not in my image from last week. Fabrice, we need not add this property to tarako. NFC is off by default.

(In reply to James Zhang from comment #18) > (In reply to Fabrice Desré [:fabrice] from comment #17) > > (In reply to James Zhang from comment #16) > > > Ying, please add ro.moz.nfc.enabled=false on fugu and tarako. > > > > James, did that happen? It's not in my image from last week. > > Fabrice, we need not add this property to tarako. NFC is off by default. I'll check it with ttsai today.

You need to set that to let gecko know that there is no nfc support on the device and prevent it to instanciate some services.

use status-b2g-v1.3T?, remove [tarako] in whiteboard