Closed Bug 947204 Opened 11 years ago Closed 11 years ago

user.js can be installed as file name /data/local

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.3 C1/1.4 S1(20dec)

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

(Whiteboard: [c= p=1 s= u=])

Attachments

(1 file)

Bug 945903 changed the location of installed webapps for eng builds from /data/local/webapps to /system/b2g/webapps. This is all fine and good, but it seems that in some cases our scripts were relying on the adb push to /data/local/webapps to create the /data/local/ directory if it was missing. In particular, now if the /data/local directory is missing then install-gaia.py will do: adb push user.js /data/local Normally /data/local is a directory so this installs the file within the directory. If the directory is missing, however, it instead copies the user.js to a file called "/data/local". The end result is that b2g cannot boot and spits out errors regarding failures to open the settings DB.
This pull request attempts to avoid this problem by using the full destination path when installing user.js.
Attachment #8343734 - Flags: review?(yurenju.mozilla)
Comment on attachment 8343734 [details] Pull request at https://github.com/mozilla-b2g/gaia/pull/14462 makes sense, r=yurenju. thanks for your patch! George, please update this change to your commit on bug 945553.
Attachment #8343734 - Flags: review?(yurenju.mozilla) → review+
and I did a little experiment to push a file into a directory which doesn't exist and it works :-)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: