Closed
Bug 947286
Opened 11 years ago
Closed 11 years ago
[Exif Parser] Consolidate all global variables in a single one
Categories
(Firefox OS Graveyard :: Gaia::Gallery, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dmarcos, Assigned: dmarcos)
References
Details
Attachments
(1 file)
The Exif parser now exposes several APIs in several global variables. We have to consolidate all the APIs under a single global.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dmarcos
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8343896 -
Flags: review?(dflanagan)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8343896 [details]
Pull Request
Looks okay to me. I left a few nits on github. (added them to the jpeg.js file instead of the individual component files that make it up.)
Before landing, please:
- squash your commits
- make sure gjslint passes
- consider renaming JPEG.BlobView to JPEG.RWBlobView to indicate that it is different than BlobView
- consider changing the names jpeg.js and JPEG to jpeg_metadata.js and JPEGMetadata so it is clear that this is not a library that manipulates the actual jpeg image data.
Attachment #8343896 -
Flags: review?(dflanagan) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Merged in master:
https://github.com/mozilla-b2g/exif-parser/commit/f82a0de0da1fb0d9a6eb808dcd84e0b43e76d06c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•