PerProfileContentProvider was written (and named) before all our other content providers kept track of per-profile databases. However, PerProfileContentProvider is still different from our other content providers because it keeps track of a SQLiteBridge per profile (rather than a SQLiteOpenHelper). So, I think we should rename this file to make it easier to understand its purpose.

(In reply to :Margaret Leibovic from comment #0) > PerProfileContentProvider was written (and named) before all our other > content providers kept track of per-profile databases. However, > PerProfileContentProvider is still different from our other content > providers because it keeps track of a SQLiteBridge per profile (rather than > a SQLiteOpenHelper). > > So, I think we should rename this file to make it easier to understand its > purpose. Can I grab this bug to work on!? I'm new to firefox mobile development, i already compiled the code and i wanna to join to the development.

(In reply to Marcos Cezar Mendes da Costa Junior from comment #1) > (In reply to :Margaret Leibovic from comment #0) > > PerProfileContentProvider was written (and named) before all our other > > content providers kept track of per-profile databases. However, > > PerProfileContentProvider is still different from our other content > > providers because it keeps track of a SQLiteBridge per profile (rather than > > a SQLiteOpenHelper). > > > > So, I think we should rename this file to make it easier to understand its > > purpose. > > Can I grab this bug to work on!? I'm new to firefox mobile development, i > already compiled the code and i wanna to join to the development. Sure thing! If you already have a build environment set up, you're well on your way! Is the description I provided clear enough for you? If you haven't already found it, this is the file I'm talking about: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/db/PerProfileContentProvider.java You'll also need to update the places where that class is used: http://mxr.mozilla.org/mozilla-central/search?string=PerProfileContentProvider Once you've made changes locally, you can follow these directions to make a patch, and set the review? flag to me: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F Feel free to hop in #mobile on irc.mozilla.org if you have any questions!

Verify if i miss anything ok!? Sorry for the late.

The missing part of the patch i forgot to attach.

This is the official with all changes in one unique patch.

Comment on attachment 8355854 [details] [diff] [review] renamePerProfileContentProvider.patch Review of attachment 8355854 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch! This is looking good, but instead of removing the old file and adding a new one, we should do an |hg rename| to preserve hg blame.

Hey Marcos, how's it going? If you upload an updated version of your patch, I can give it and r+ and help you land it :)

I just updated your patch to address my comment, and landed it for you: https://hg.mozilla.org/integration/fx-team/rev/c95c77bbd0d1 Thanks for your help! Let us know if you need help finding more bugs to work on :)

Comment on attachment 8355854 [details] [diff] [review] renamePerProfileContentProvider.patch Review of attachment 8355854 [details] [diff] [review]: ----------------------------------------------------------------- (Post-hoc r+ with comments addressed)

Ok Margaret, Thanks. I've been too busy in the last month sorry for the slow answer i'm alive kkkkkkkkk.