Description: If the user taps on the add to contacts button on the dialer, the asterisk key will register that it has been tapped as well. Repro Steps: 1) Updated Buri to Build ID: 20131206040203 2) Tap on the "Dialer" icon. 3) Tap on the "Call Log" icon at the bottom of the screen. 4) Tap on the "Contacts" icon at the bottom of the screen. 5) Tap on the "number pad" icon at the bottom of the screen. 6) Tap on the grayed out "Add to contacts" button. Actual: Both the "asterisk key" and the "add to contacts" button will register a touch event. Expected: When the user taps on the "add to contacts" button, the "asterisk key" does not activate as well. Environmental Variables Device: Buri v 1.3.0 Mozilla RIL Build ID: 20131206040203 Gecko: http://hg.mozilla.org/mozilla-central/rev/1401e4b394ad Gaia: 8fca2ca67e8a6022fe6ed8cb576e5d59dfb5237f Platform Version: 28.0a1 Notes: Repro frequency: 100% See attached: video clip, logcat Please note this issue only occurs from following the above steps. Opening the dialer and immediately trying to reproduce this issue without going to the call log and contacts first will not cause this issue to occur.

This issue does not occur on the Buri v 1.2.0 COM RIL Environmental Variables Device: Buri v 1.2.0 COM RIL Build ID: 20131204004003 Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/758f3fb32dda Gaia: 8d762f3376318fd6be390432db750ae4904c9ab6 Platform Version: 26.0 RIL Version: 01.02.00.019.102 The "asterisk key" does not register a touch event when the "add to contacts" button is being tapped.

This could potentially have larger implications depending on what's actually causing this. I know event fluffing is enabled on 1.3 - could that be causing this issue? It's also a regression in core phone functionality.

This issue started to occur on the Buri 1.3 Build ID: 20131019040204 Gaia d0861c2913a57cb681ec4cd4d52d73cc0f479ac9 SourceStamp e25e62d174ed BuildID 20131019040204 Version 27.0a1 Last working Buri 1.3 Build ID: 20131018040217 Gaia 18c2ab4b7b2d4cacee90fb85e97354142b2fad4a SourceStamp 855da6d8a327 BuildID 20131018040217 Version 27.0a1

triage: 1.3+ regression

Event fluffing?

Seems like a fluffing issue.

I can't reproduce the bug with this patch. Tapping between the 'add contact' or '*' will trigger one or the other (depending on where I tap) but not both like you could see in the video.

Comment on attachment 8356062 [details] Gaia PR Hey Eitan, I don't think so but just to check: I'm not making an accessibility faux-pas with this change right?

Comment on attachment 8356062 [details] Gaia PR Looks good to me. I would have preferred to use <button> directly but that's a bigger patch.

Comment on attachment 8356062 [details] Gaia PR Generally, this is correct. Specifically what we want here is a role of 'key' on the actual keypad numerals and #,* (which is our own invention and not proper ARIA). See bug #808596 for some context why. I implemented this in the keyboard in bug #918602. Please note, not everything gets the role of key. Only the actual key pad buttons. The add-contact and call button still get the role of button.

(In reply to Eitan Isaacson [:eeejay] from comment #11) > Comment on attachment 8356062 [details] > Gaia PR > > Generally, this is correct. Specifically what we want here is a role of > 'key' on the actual keypad numerals and #,* (which is our own invention and > not proper ARIA). See bug #808596 for some context why. I implemented this > in the keyboard in bug #918602. > > Please note, not everything gets the role of key. Only the actual key pad > buttons. The add-contact and call button still get the role of button. Glad I asked, updated :)

FTR, the Gaia rev is better to use rather than PR :) Master: https://github.com/mozilla-b2g/gaia/commit/f92169bf413fded0414d56eb393d14cc32fe5a8c

Uplifted f92169bf413fded0414d56eb393d14cc32fe5a8c to: v1.3: f5ec3807134743adb41ad0f270915db0e442bfba