Wilfred Mathanaraj [:WDM] Reporter
	Description • 11 years ago

As a user, I should be able to --edit-- SIM PIN2 and PUK2 for each of the Dual SIM.

Acceptance Criteria

AC1: I want the interface to match to how I edit PIN1 and PUK1

	Enpei
	Comment 1 • 11 years ago

(In reply to Wilfred Mathanaraj [:WDM] from comment #0)
> As a user, I should be able to --edit-- SIM PIN2 and PUK2 for each of the
> Dual SIM.
> 
> Acceptance Criteria
> 
> AC1: I want the interface to match to how I edit PIN1 and PUK1


Hi Wilfred,

Edit here means to change the PIN code, right? If so, are we able to edit PUK?

Alos AC1 should be "I want the interface to match to how I edit PIN2...", right?

Thanks.

	Wilfred Mathanaraj [:WDM] Reporter
	Comment 2 • 11 years ago

correct  - we need to be able t edit PIN and PUK. Is your question that we dont support editing of PUK yet in single sim implementation? if this is the case then we can skip editing of PUK in single sim solution.
I have not been able to lock my device yet since I only have a single SIM to see if we can edit the PUK in any way.

AC1: correct but I also dont think there should be any big difference between editing PIN1 or PIN2 - the UI should be pretty similar.

	Enpei
	Comment 3 • 11 years ago

(In reply to Wilfred Mathanaraj [:WDM] from comment #2)
> correct  - we need to be able t edit PIN and PUK. Is your question that we
> dont support editing of PUK yet in single sim implementation? if this is the
> case then we can skip editing of PUK in single sim solution.
> I have not been able to lock my device yet since I only have a single SIM to
> see if we can edit the PUK in any way.
> 
> AC1: correct but I also dont think there should be any big difference
> between editing PIN1 or PIN2 - the UI should be pretty similar.

Hi Wilfred, yes, there is no edit PUK feature in single SIM implementation.

	Joe Cheng [:jcheng] (please needinfo)
	Comment 4 • 11 years ago

features should not block release, remove blocking flag

	Fabien Cazenave [:kaze]
	Comment 5 • 11 years ago

I’m afraid I have to unassign myself for now, as I still don’t have any DSDS device right now.

Feel free to take this bug, I’ll be happy to review patches or do some mentoring.

	Joe Cheng [:jcheng] (please needinfo)
	Comment 6 • 11 years ago

Hi David, let's find someone to take this bug. thanks

	David Scravaglieri [:scravag]
	Comment 7 • 11 years ago

clear ni?

	Enpei
	Comment 8 • 11 years ago

Test cases are in moztrap: https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=100&sortfield=created_on&sortdirection=desc&filter-tag=2564

	Sergi Mansilla [:sergi] (Telenor) [PTO] Assignee
	Comment 9 • 11 years ago

I am temporarily blocked due to the lack of having 2 SIMs with PIN2 enabled. Hopefully I will receive them tomorrow.

	Sergi Mansilla [:sergi] (Telenor) [PTO] Assignee
	Comment 10 • 11 years ago

Taking on this bug now.

	Sergi Mansilla [:sergi] (Telenor) [PTO] Assignee
	Comment 11 • 11 years ago

I understand that the PIN2 change dialog should be in SIM Manager -> SIM Security just as the normal PIN change dialogs are, right? A confirmation from UX would be great.

	Wilfred Mathanaraj [:WDM] Reporter
	Comment 12 • 11 years ago

yes i would think so - I am NI Carrie to comment on it.

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 13 • 11 years ago

Hi guys, 

Currently, if users want to edit SIM PIN 2 on single SIM devices, they shall go "Call settings" and then enter a default SIM PIN 2 to activate the PIN 2 edit function.
Hence, If we want to keep it consistent, for DSDS, it should not be the SIM security in SIM manager (that's for SIM 1 and SIM 2's PIN 1 edit). It should be kept in FDN. Thanks!

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 14 • 11 years ago

Hi Sergi, 

Keeping the PIN 2 edit in FDN, you can refer Neo's spec from bug 921971. There will be two entry points (SIM 1/ SIM 2) in Call settings and then they can edit PIN2 in each FDN section. Thanks!

	Sergi Mansilla [:sergi] (Telenor) [PTO] Assignee
	Comment 15 • 11 years ago

Hi Carrie,

Ok, so all PIN2 editing will be done through the current `Reset PIN2` button inside FDN, am I right? If that's correct, this issue is fixed automatically by the work done in https://bugzilla.mozilla.org/show_bug.cgi?id=921971.

	Carrie Wang [New account: carrie75521@gmail.com]
	Comment 16 • 11 years ago

Yes, exactly! :)

	Sergi Mansilla [:sergi] (Telenor) [PTO] Assignee
	Comment 17 • 11 years ago

Perfect, I'll close this issue when 921971 is resolved, then.

	Enpei
	Comment 18 • 11 years ago

Verified on Fugu
Gaia      b193de26878dae53a4b20b78e453ed07bfbf4d09
Gecko     85f09a609c5d96f23988df41c58932e57d1e398e
BuildID   20140311053055
Version   30.0a1

Passed.