Closed
Bug 947985
Opened 11 years ago
Closed 10 years ago
Icon Request: WMF icon for 'Settings'
Categories
(Firefox OS Graveyard :: FindMyDevice, defect, P1)
Tracking
(b2g-v2.0 verified, b2g-v2.1 verified)
VERIFIED
FIXED
2.0 S5 (4july)
People
(Reporter: elan, Assigned: bryan)
References
Details
Attachments
(7 files, 6 obsolete files)
(deleted),
application/pdf
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
application/zip
|
Details | |
(deleted),
text/x-github-pull-request
|
arthurcc
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details |
(deleted),
application/zip
|
Details | |
(deleted),
text/x-github-pull-request
|
Details | |
(deleted),
video/mp4
|
Details |
Greetings,
In the current Firefox OS builds which include WMF (ggp, dougt has them), we are using the airplane icon as a placeholder. It would be good to obtain a new icon. Please note: the naming for this feature is being reconsidered. It would be great to obtain the new icon and/or recommendation for an existing icon by EOB tomorrow, Dec 10th. Thank you.
Comment 1•11 years ago
|
||
Hi Erin,
Bugs related to branding should be submitted through this form with the Brand Engagement team: https://bugzilla.mozilla.org/form.creative
Reporter | ||
Comment 2•11 years ago
|
||
ok, I am going close this bug.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
Reporter | ||
Comment 3•11 years ago
|
||
Reopening this bug; Peter La will be providing iconography.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Reporter | ||
Comment 4•11 years ago
|
||
Hi Erin,
We currently have Carol Huang from the Taipei Visual team working on this icon. It occured to me that this icon could/should be very connected to the final name and branding associated with Where's My Fox, and perhaps not just a generic icon.
Do you know anything about what is in the works for the naming/branding of Where's My Fox?
Reporter | ||
Comment 6•11 years ago
|
||
Hi Peter,
Yes, I'm just getting final approval from marketing but we should be good with "Find my device". I will comment here once we have the final call. Discussion can be found, here: bug 951798. I agree with you and I made the naming discussion bug block this one. :) Thank you!
Reporter | ||
Comment 7•11 years ago
|
||
Peter, we are proceeding with "Find my device". Hope this helps with the icon design. Do ping me as needed.
Comment 8•11 years ago
|
||
The attachment is the icon for "Find My Device" in Settings.
There was some desire expressed to find a more appropriate icon to represent find my device. The magnifying icon overlaid on a device seems to imply searching on device. Using a set of binoculars should help to imply "find" more readily.
Assignee | ||
Comment 10•11 years ago
|
||
A 2x version of the same find my device icon.
Comment 11•11 years ago
|
||
Comment on attachment 8400142 [details]
icon_settings_findmydevice@2.png
I'm not really supposed to use this flag this way, but asking Patryk for a review on this new icon.
Attachment #8400142 -
Flags: ui-review?(padamczyk)
Comment 12•11 years ago
|
||
Comment on attachment 8400142 [details]
icon_settings_findmydevice@2.png
It looks like a castle to me. Isn't this related to "where's my fox"? If so is there any prior art/branding associated with that. If so we should use that.
Otherwise I would suggest doing something with a radar blip, or gps location. This seems to be used a common metaphor in many other OS'
Attachment #8400142 -
Flags: ui-review?(padamczyk) → ui-review-
Comment 13•11 years ago
|
||
Also the sizes needed are:
@1x
@1.5x
@2x
@2.25x
@3x
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(bryan)
Reporter | ||
Updated•11 years ago
|
Target Milestone: --- → 2.0 S1 (9may)
Comment 15•11 years ago
|
||
Hi all,
This bug has been sitting for a week with no updates. Can someone provide a little insight into the current status?
Thanks!
Jared
Comment 16•11 years ago
|
||
Whoops! Sorry, bugzilla caching got me this time. I didn't see anything past c13 until *after* I submitted my comment.
Assignee | ||
Comment 17•11 years ago
|
||
A new design for this icon is in the works. Patryk Adamczyk, Carol Huang, and I are coming up with new alternatives, and Patryk will decide which to use soon.
Flags: needinfo?(bryan)
Reporter | ||
Updated•11 years ago
|
Target Milestone: 2.0 S1 (9may) → 2.0 S2 (23may)
Comment 18•11 years ago
|
||
Hi,
the attachment is the updated sprite with Find My Device icon.
Comment 19•11 years ago
|
||
I'm assuming this is the final icon, so I filed a pull request to swap it in. Please let me know if this is not the case.
Attachment #8425480 -
Flags: review?(21)
Attachment #8425480 -
Flags: review?(21) → review+
Comment 20•11 years ago
|
||
Hi,
Sorry!! I did a little change on the icon. And now is the final one. Please switch to the new images. Thanks a lot!
Attachment #8425208 -
Attachment is obsolete: true
Comment 21•11 years ago
|
||
No problem, I updated the pull request. Carrying over r+ from :vingtetun.
Updated•11 years ago
|
Keywords: checkin-needed
Comment 22•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
status-b2g-v2.0:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Reporter | ||
Comment 23•10 years ago
|
||
We need to revisit current design. Not approved by legal.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Updated•10 years ago
|
Assignee: swilkes → bryan
Assignee | ||
Comment 24•10 years ago
|
||
We have new settings icon. Here's the final version.
Comment 25•10 years ago
|
||
Bryan, I believe the sprites need to be updated. Note how there are new icons after FMD's in the current sprite: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/style/images/icons_sprite.gif
Flags: needinfo?(bryan)
Assignee | ||
Comment 26•10 years ago
|
||
Great catch GGP. Thanks!
Here's the fixed graphics.
Flags: needinfo?(bryan)
Comment 27•10 years ago
|
||
Attachment #8425480 -
Attachment is obsolete: true
Attachment #8444752 -
Flags: review?(arthur.chen)
Comment 28•10 years ago
|
||
Comment on attachment 8444752 [details]
gaia pull request
r=me, thanks.
Attachment #8444752 -
Flags: review?(arthur.chen) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 29•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/57da30f405ba37a5d4844f32bb292271b81faee2
I'm going to go out on a limb that this needs uplifting to v2.0 as well? Please request Gaia v2.0 approval on the patch if that's the case.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
status-b2g-v2.1:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: 2.0 S2 (23may) → 2.0 S5 (4july)
Comment 30•10 years ago
|
||
Comment on attachment 8444752 [details]
gaia pull request
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 8444752
[User impact] if declined: Wrong icon for FMD in the Settings app
[Testing completed]: Travis and manual
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None
Attachment #8444752 -
Flags: approval-gaia-v2.0?(bbajaj)
Updated•10 years ago
|
Attachment #8444752 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Comment 31•10 years ago
|
||
This doesn't merge clearly to v2.0.
Flags: needinfo?(bryan)
Keywords: branch-patch-needed
Comment 33•10 years ago
|
||
Hmm, the keyboard icon in the third row, second column looks different in 2.0 and in master (before this patch), so I bet that's where the conflict is. Bryan, I think we'll need another sprite from you, please.
Flags: needinfo?(ggoncalves)
Assignee | ||
Comment 34•10 years ago
|
||
I would be happy to massage the sprite. Where can I find the 2.0 sprite with the slightly different keyboard icon?
Flags: needinfo?(bryan)
Comment 35•10 years ago
|
||
Hi Bryan,
I've emailed you the lasted files of Settings icons.
Please use it and replace the WMF icon!! thank you!! (remember to export to GIF files as what we have right now.)
let me know if you have any other question :)
Flags: needinfo?(bryan)
Assignee | ||
Comment 36•10 years ago
|
||
OK this should really be the final version. These were made with the official source Photoshop Files. However, there's no detectable difference from the previous version.
Attachment #8400141 -
Attachment is obsolete: true
Attachment #8400142 -
Attachment is obsolete: true
Attachment #8443805 -
Attachment is obsolete: true
Attachment #8444749 -
Attachment is obsolete: true
Flags: needinfo?(bryan)
Comment 37•10 years ago
|
||
Attaching 2.0 PR.
Comment 38•10 years ago
|
||
Keywords: branch-patch-needed
Comment 39•10 years ago
|
||
This issue has been verified successfully on Flame v2.0 & v2.1
STR:
1. Launch Settings app.
2. Check the icon of Find My Device.
**The icon show as a telescope.
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.0 versions:
Gaia-Rev 8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID 20141127000203
Version 32.0
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20141127.034818
FW-Date Thu Nov 27 03:48:29 EST 2014
Bootloader L1TC00011880
Flame 2.1 versions:
Gaia-Rev 5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID 20141127001201
Version 34.0
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20141127.035005
FW-Date Thu Nov 27 03:50:16 EST 2014
Bootloader L1TC00011880
You need to log in
before you can comment on or make changes to this bug.
Description
•