Closed
Bug 948096
Opened 11 years ago
Closed 11 years ago
Add a warning when window._content is used
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Keywords: addon-compat)
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
myk
:
review+
|
Details | Diff | Splinter Review |
This API has been deprecated for nearly a decade now. People should be using window.content instead so we can remove this API.
Sadly, there's a lot of copy/paste of _content in extensions, at first glance. Jorge, is it reasonable for us to add a warning here anyway?
Flags: needinfo?(jorge)
|
||
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
|
||
Comment 1•11 years ago
|
||
And we should make this [ChromeOnly] until it is completely removed, if possible.
Keywords: addon-compat,
site-compat
|
|
Assignee | |
Comment 2•11 years ago
|
||
Already done, in bug 946564. So no site-compat here.
Keywords: site-compat
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8345661 -
Flags: review?(myk)
Attachment #8345661 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•11 years ago
|
||
Myk, could you look at the webapprt bits?
Whiteboard: [need-review]
|
||
Updated•11 years ago
|
Attachment #8345661 -
Flags: review?(bugs) → review+
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8345661 [details] [diff] [review]
Warn when people use window._content.
r=myk on the webapprt/ bit.
Attachment #8345661 -
Flags: review?(myk) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Flags: in-testsuite-
Whiteboard: [need-review]
Target Milestone: --- → mozilla29
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•