Closed Bug 948346 Opened 11 years ago Closed 11 years ago

[Messages] When a message has multiple lines, the text is cut off.

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3+, firefox29 affected, b2g-v1.2 unaffected, b2g-v1.3 fixed)

Status:
VERIFIED FIXED
Milestone:
1.3 C1/1.4 S1(20dec)
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox29 --- affected
b2g-v1.2 --- unaffected
b2g-v1.3 --- fixed

People

(Reporter: lolimartinezcr, Assigned: fcampo)

References

Details

(Keywords: regression)

Attachments

(4 files)

2013-12-10-10-49-25.png
(deleted), image/png
Details
2013-12-10-10-48-26.png
(deleted), image/png
Details
link to PR - https://github.com/mozilla-b2g/gaia/pull/14570
(deleted), text/x-github-pull-request
julienw
: review+
Details
Messages in the french locale has a bigger "send" button
(deleted), image/png
Details
Attached image 2013-12-10-10-49-25.png (deleted) —
master 12/10 Gecko 0caa62e Gaia 6865061 Steps: 1.Tap message aplication 2. Write a message with multiple lines. Expected Result: Text isn't cut off. Actual Result: Text is cut off
Attached image 2013-12-10-10-48-26.png (deleted) —
blocking-b2g: --- → 1.3?
Summary: [SMS] When a message has multiple lines, the text is cut off. → [Message] When a message has multiple lines, the text is cut off.
See the attachments for information about the actual bug. I'm quite sure this is a regression of bug 885680 but I'd like to check this.
Blocks: 885680
Keywords: qawanted, regression, regressionwindow-wanted
QA Contact: jzimbrick
Regression Window: Last Working Environmental Variables: Device: Buri v1.3 Mozilla RIL BuildID: 20131209053402 Gaia: 1d45d1dc3201059d5c8f2efdeb92c04576d8e161 Gecko: 9f12a9fab080 Version: 28.0a1 Base Image: V1.2_20131115 First Broken Environmental Variables: Device: Buri v1.4 Mozilla RIL BuildID: 20131210040206 Gaia: c952e2756c03eceb4de6a3eba15651741a62f9e8 Gecko: df82be9d89a5 Version: 29.0a1 Base Image: V1.2_20131115 Removing regressionwindow-wanted, was there something more wanted for the qawanted tag?
Keywords: regressionwindow-wanted
For QA Wanted - can you check if this reproduces on 1.2?
This issue does not occur in the latest Buri 1.2 Mozilla build. Environmental Variables: Device: Buri v1.2 Mozilla RIL BuildID: 20131210004008 Gaia: 3bede56043379283cb0f6673730f91be88018d13 Gecko: e535d93d88ad Version: 26.0 Base Image: V1.2_20131115
status-b2g-v1.2: --- → unaffected
status-firefox28: --- → unaffected
status-firefox29: --- → affected
Keywords: qawanted
Summary: [Message] When a message has multiple lines, the text is cut off. → [Messages] When a message has multiple lines, the text is cut off.
Yup, confirming it's because of bug 885680, I changed the send button layout to absolute and message grows till the limit. Fix coming!
Assignee: nobody → fernando.campo
Attachment #8345856 - Flags: review?(felash)
In the end, we should use either flex-box or display: table to do this... but not in 1.3 I guess.
Comment on attachment 8345856 [details] link to PR - https://github.com/mozilla-b2g/gaia/pull/14570 This solution does not work because the button width depends on the locale.
Attachment #8345856 - Flags: review?(felash) → review-
Since it is caused by Bug 885680 (part of v1.3 branch) status-firefox:28 should be affected. Asking qa to confirm it. Thanks!
Keywords: qawanted
Comment on attachment 8345856 [details] link to PR - https://github.com/mozilla-b2g/gaia/pull/14570 r=me, thanks for the fix! please file a new bug for the fact that the line below "subject" stops at exactly 7rem instead of stopping at where the button is (see attachment). Maybe that bug could handle the flex-box conversion for the "composer" area.
Attachment #8345856 - Flags: review- → review+
(In reply to Noemí Freire (:noemi) from comment #11) > Since it is caused by Bug 885680 (part of v1.3 branch) status-firefox:28 > should be affected. Asking qa to confirm it. Thanks! After checking the latest 1.3 build, I can confirm that this issue does reproduce on that branch. I'll update the tracking flag accordingly. Environmental Variables: Device: Buri v1.3 Mozilla RIL BuildID: 20131211004003 Gaia: 7a2ccae2a546ac4d981d250272dafa630c926422 Gecko: 6bb84d0bc170 Version: 28.0a2 Base Image: V1.2_20131115
status-b2g-v1.3: --- → affected
status-firefox28: unaffected → ---
Keywords: qawanted
triage: 1.3+ regression
blocking-b2g: 1.3? → 1.3+
Check this bug in 1.3 12/12 Device: unagi Gecko c8ebb7f Gaia cbd2921 I can confirm that this issue is reproduce.
Tested 1.2 and this problem not is reproducible in this branch 12/12 Gecko 4f9e42b Gaia bd559e
all green, merged on master https://github.com/mozilla-b2g/gaia/commit/ab0b63e94048223c96a2d0e9f4f189a75b437922 thanks for quick review! opened a bug for the flex layout (bug 949457)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Hey John, any chance to get this uplifted? Are there any flag we miss here? Thanks!
Flags: needinfo?(jhford)
[v1.3 f55764b] Merge pull request #14570 from fcampo/mms-message-width-948346
status-b2g-v1.3: affected → fixed
Flags: needinfo?(jhford)
Verified on latest v1.3 build (01/07): Gecko-118cfbe Gaia-ff5f06d
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: