Closed
Bug 948472
Opened 11 years ago
Closed 11 years ago
Test for Bug 938219: "add to an existing contact" activity
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: julienw, Assigned: Bebe)
References
Details
Attachments
(1 file)
Hey,
having such an integration test could be very useful:
1. User launches the SMS app
2. User taps on a thread for an unmatched contact (I mean: for a plain phone number)
3. User taps on the header
4. User taps on "add to an existing contact"
5. User chooses an existing contact
6. User presses "done"
7. User is moved back to the SMS app
Note that this case is failing until bug 938219 is fixed.
Reporter | ||
Updated•11 years ago
|
Updated•11 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•11 years ago
|
||
I will take this
Assignee: nobody → florin.strugariu
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8385415 -
Flags: review?(zcampbell)
Attachment #8385415 -
Flags: review?(viorela.ioia)
Comment 3•11 years ago
|
||
Comment on attachment 8385415 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835
The test runs ok, but there are a few comments you should address.
Attachment #8385415 -
Flags: review?(viorela.ioia) → review-
Assignee | ||
Updated•11 years ago
|
Attachment #8385415 -
Flags: review- → review?(viorela.ioia)
Updated•11 years ago
|
Attachment #8385415 -
Flags: review?(viorela.ioia) → review+
Comment 4•11 years ago
|
||
Comment on attachment 8385415 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835
r-
functionally it works very well but for some nits, comments in the pull.
Also this needs to be in the messages folder not contacts, as this flow is owned by the messsage team.
Attachment #8385415 -
Flags: review?(zcampbell) → review-
Assignee | ||
Updated•11 years ago
|
Attachment #8385415 -
Flags: review- → review?(zcampbell)
Assignee | ||
Updated•11 years ago
|
Attachment #8385415 -
Flags: review?(robert.chira)
Attachment #8385415 -
Flags: review?(bob.silverberg)
Updated•11 years ago
|
Attachment #8385415 -
Flags: review?(robert.chira) → review-
Assignee | ||
Updated•11 years ago
|
Attachment #8385415 -
Flags: review- → review?(robert.chira)
Updated•11 years ago
|
Attachment #8385415 -
Flags: review?(robert.chira) → review+
Comment 5•11 years ago
|
||
Comment on attachment 8385415 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835
super tiny nit, but after that ready to merge.
Attachment #8385415 -
Flags: review?(zcampbell) → review-
Comment 6•11 years ago
|
||
Comment on attachment 8385415 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835
Comments in the PR.
Attachment #8385415 -
Flags: review?(bob.silverberg) → review-
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8385415 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835
Updated the pull.
Can you guys/gals review it.
As Zac is in PTO I did not updated his review request but see comment #5
Attachment #8385415 -
Flags: review?(viorela.ioia)
Attachment #8385415 -
Flags: review?(bob.silverberg)
Attachment #8385415 -
Flags: review-
Attachment #8385415 -
Flags: review+
Updated•11 years ago
|
Attachment #8385415 -
Flags: review?(viorela.ioia) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #8385415 -
Flags: review?(andrei.hutusoru)
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment #8385415 -
Flags: review?(bob.silverberg)
Attachment #8385415 -
Flags: review?(andrei.hutusoru)
Attachment #8385415 -
Flags: review+
You need to log in
before you can comment on or make changes to this bug.
Description
•