Closed Bug 948472 Opened 11 years ago Closed 11 years ago

Test for Bug 938219: "add to an existing contact" activity

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julienw, Assigned: Bebe)

References

Details

Attachments

(1 file)

Hey, having such an integration test could be very useful: 1. User launches the SMS app 2. User taps on a thread for an unmatched contact (I mean: for a plain phone number) 3. User taps on the header 4. User taps on "add to an existing contact" 5. User chooses an existing contact 6. User presses "done" 7. User is moved back to the SMS app Note that this case is failing until bug 938219 is fixed.
Priority: -- → P2
I will take this
Assignee: nobody → florin.strugariu
Status: NEW → ASSIGNED
Attachment #8385415 - Flags: review?(zcampbell)
Attachment #8385415 - Flags: review?(viorela.ioia)
Comment on attachment 8385415 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835 The test runs ok, but there are a few comments you should address.
Attachment #8385415 - Flags: review?(viorela.ioia) → review-
Attachment #8385415 - Flags: review- → review?(viorela.ioia)
Attachment #8385415 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8385415 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835 r- functionally it works very well but for some nits, comments in the pull. Also this needs to be in the messages folder not contacts, as this flow is owned by the messsage team.
Attachment #8385415 - Flags: review?(zcampbell) → review-
Attachment #8385415 - Flags: review- → review?(zcampbell)
Attachment #8385415 - Flags: review?(robert.chira)
Attachment #8385415 - Flags: review?(bob.silverberg)
Attachment #8385415 - Flags: review?(robert.chira) → review-
Attachment #8385415 - Flags: review- → review?(robert.chira)
Attachment #8385415 - Flags: review?(robert.chira) → review+
Comment on attachment 8385415 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835 super tiny nit, but after that ready to merge.
Attachment #8385415 - Flags: review?(zcampbell) → review-
Comment on attachment 8385415 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835 Comments in the PR.
Attachment #8385415 - Flags: review?(bob.silverberg) → review-
Comment on attachment 8385415 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16835 Updated the pull. Can you guys/gals review it. As Zac is in PTO I did not updated his review request but see comment #5
Attachment #8385415 - Flags: review?(viorela.ioia)
Attachment #8385415 - Flags: review?(bob.silverberg)
Attachment #8385415 - Flags: review-
Attachment #8385415 - Flags: review+
Attachment #8385415 - Flags: review?(viorela.ioia) → review+
Attachment #8385415 - Flags: review?(andrei.hutusoru)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #8385415 - Flags: review?(bob.silverberg)
Attachment #8385415 - Flags: review?(andrei.hutusoru)
Attachment #8385415 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: