Closed Bug 94870 Opened 23 years ago Closed 23 years ago

Autocomplete ignores history entires starting with "www"

Categories

(SeaMonkey :: Location Bar, defect)

x86
All
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.4

People

(Reporter: alex, Assigned: hewitt)

References

Details

(Keywords: regression)

Attachments

(3 files)

From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.3+) Gecko/20010810 BuildID: 2001081003 Autocomplete seems to be ignoring history entries starting with "www". Reproducible: Always Steps to Reproduce: 1. Load "www.google.com" to ensure that it's in your history. 2. Goto URL Bar and type "www.goo" Actual Results: At this point, autocomplete drop-down should suggest "http://www.google.com" Expected Results: No autocomplete suggestion. Interestingly enough, after step 2, if you type just "goo", autocomplete cooperates (but that's just bug 63421 working properly). I haven't found any dupes, though it looks like bug 94612 is close (though separate, I think).
*** Bug 94872 has been marked as a duplicate of this bug. ***
And Linux. OS: All
OS: Windows 2000 → All
Look to the duped bug 94872 for arguments why it is a bad behavior.
Yes, it's very clearly bad behaviour. www.something.com, home.something.com and something.com may be on different ports for that matter - or there may be no server at all on something.com Btw.. autocomplete doesn't trigger on http:// either: It only triggers if i write slashdot.org (not when i write http://slashdot.org or http://www.slashdot.org)
*** Bug 94946 has been marked as a duplicate of this bug. ***
it will be mostfreq shortly. flagging.
Keywords: mostfreq, regression
Changing severity to major. It *is* a major loss of autocomplete finctionality.
Severity: normal → major
*** Bug 95064 has been marked as a duplicate of this bug. ***
*** Bug 95222 has been marked as a duplicate of this bug. ***
Blocks: advocacybugs
*** Bug 95438 has been marked as a duplicate of this bug. ***
Propose target milestone -> mozilla0.9.4
Nominating for mozilla0.9.4 per request by Alex
Keywords: mozilla0.9.4
nav triage team: Reassigning to Joe Hewitt since he owns auto-complete widget.
Assignee: alecf → hewitt
working on this, will have a fix shortly
Status: NEW → ASSIGNED
Keywords: mozilla0.9.4
Target Milestone: --- → mozilla0.9.4
The problem here is that the current autocomplete search slices off certain prefixes (like "http://" and "www.") from both the url you type, and all urls in the history, before it compares them. What should really be done is to not cut any prefixes from the typed url, and only cut prefixes from the history urls if those prefixes are not on the typed url. This way, if you type "www.moz", the search will compare this to "http://mozilla.org" and fail, but it will compare it to "http://www.mozilla.org" and match.
Attached patch patch to fix (deleted) — Splinter Review
*** Bug 94612 has been marked as a duplicate of this bug. ***
* AutoCompleteExcludeInfo doesn't look like it will work for strings that start with something from both tables (eg "http://www."), since both searches do "Substring(aURL, 0, ...". and a couple of nits: * instead of using "protocol" and "domain" in your variables, it would be more obvious to the reader if names like "schemePrefix" and "hostnamePrefix" were used. * how about adding a comment at the decl of AutoCompleteExclude explaining a bit about it?
* AutoCompleteExcludeInfo does work for strings that start with items from both tables, since it cuts the string between each loop I'll address your other comments and post a new patch.
Attached patch revised patch (deleted) — Splinter Review
Attached patch patch, take 3 (deleted) — Splinter Review
Looks good. My only nit would be to create the AutoCompleteExclude struct on the stack in OnStartLookup(), and then alter the signature of AutoCompleteGetExcludeInfo() to _fill in_ the struct, rather than allocating one from the heap and returning it. Fix that, and sr=waterson
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
No longer blocks: advocacybugs
*** Bug 97420 has been marked as a duplicate of this bug. ***
VERIFIED Fixed with 20010907 builds
Status: RESOLVED → VERIFIED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: