Closed Bug 949045 Opened 11 years ago Closed 4 years ago

Persist open tabs more quickly, sync all the damn time

Categories

(Firefox for Android Graveyard :: Data Providers, defect, P5)

All
Android
defect

Tracking

(fennec+)

RESOLVED INCOMPLETE
Tracking Status
fennec + ---

People

(Reporter: rnewman, Unassigned, Mentored)

References

Details

(Whiteboard: [qa+][parallel])

Follow-on from Bug 849072.

Apparently persisting every five seconds isn't enough:

http://forums.mozillazine.org/viewtopic.php?f=47&t=2687981

And we should trigger an upload-only sync *every time* tabs changes.
tracking-fennec: --- → ?
Whiteboard: [qa+][parallel]
(In reply to Richard Newman [:rnewman] from comment #0)
> Follow-on from Bug 849072.
> 
> Apparently persisting every five seconds isn't enough:
I think this is five minutes, not five seconds
tracking-fennec: ? → +
Whiteboard: [qa+][parallel] → [qa+][parallel][mentor=rnewman]
+    private static final long PERSIST_TABS_AFTER_MILLISECONDS = 1000 * 5;

from

https://bug849072.bugzilla.mozilla.org/attachment.cgi?id=750714
(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #1)
> (In reply to Richard Newman [:rnewman] from comment #0)
> > Follow-on from Bug 849072.
> > 
> > Apparently persisting every five seconds isn't enough:
> I think this is five minutes, not five seconds

The tabs are persisted at most every five seconds (to save DB writes).  We sync at most every five minutes.
And phrased in the FxA world: we limit syncs to no more than every 45 seconds, but we don't watch for change notifications when tabs changes.
Mentor: rnewman
Whiteboard: [qa+][parallel][mentor=rnewman] → [qa+][parallel]
filter on [mass-p5]
Priority: -- → P5
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.