Closed
Bug 949195
Opened 11 years ago
Closed 11 years ago
Only call IsInRequest when JS_DEBUG.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: sstangl, Assigned: sstangl)
References
Details
(Whiteboard: [qa-])
Attachments
(2 files)
|
(deleted),
patch
|
efaust
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Per Bug 939505 Comment 17, we still have a problem where IsInRequest is conditionally defined on JS_DEBUG, but then always used by MOZ_ASSERT, which is conditionally effectful on DEBUG. Gross!
Unfortunately, we can't just make IsInRequest conditional on DEBUG, since it's baked into the library based on the value of DEBUG at library compilation time.
This papers over the issue on m-c.
Attachment #8346192 -
Flags: review?(efaustbmo)
|
Assignee | |
Comment 1•11 years ago
|
||
This papers over the issue on ESR24. Doesn't need to land -- standalone can carry separately.
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8346192 [details] [diff] [review]
Only use IsInRequest when JS_DEBUG.
Review of attachment 8346192 [details] [diff] [review]:
-----------------------------------------------------------------
Gross. r=me
Attachment #8346192 -
Flags: review?(efaustbmo) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
It's been merged into the standalone release (RC4).
|
|
Assignee | |
Comment 6•11 years ago
|
||
I'll merge it when I catch the next open tree.
|
|
Assignee | |
Comment 7•11 years ago
|
||
Assignee: nobody → sstangl
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•