Closed
Bug 949415
Opened 11 years ago
Closed 11 years ago
Array.slice does not work properly in mozContact Objects
Categories
(Core Graveyard :: DOM: Contacts, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 949197
People
(Reporter: jmcf, Unassigned)
Details
Attachments
(1 file)
(deleted),
application/zip
|
Details |
Array.slice function does not work properly with mozContact objects, particularly with properties that are string arrays. See the attached test case
Reporter | ||
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
Comment 1•11 years ago
|
||
Hey José,
have you seen this happening recently? Also, are you sure that you see this on 1.3?
Could be an issue similar to what Reuben fixed in bug 697343 comment 76, and that is appearing now that bug 697343 landed. Except bug 697343 landed on 1.4 only.
Flags: needinfo?(jmcf)
Comment 2•11 years ago
|
||
I think so because we are working together in the office and AFAIK he had installed the build 1.3 generated today
Comment 3•11 years ago
|
||
I just tried on a gecko 1.4 and I see the same behavior that we had in bug 697343 comment 76. I don't have a 1.3 here right now though but this looks like a similar issue.
I'm quite sure that slice used to work on mozContacts find results in v1.3, because we were using it in the SMS app. But I don't know for array properties.
Reuben, I think we need to kill another COW, right? Should we land also your patch in bug 697343 comment 76 to 1.3?
Flags: needinfo?(reuben.bmo)
Comment 4•11 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #3)
> Reuben, I think we need to kill another COW, right? Should we land also your
> patch in bug 697343 comment 76 to 1.3?
We need to kill several COWs, that's what bug 946294 is about. Not sure how feasible it is to land that one on 1.3 though.
Depends on: 946294
Flags: needinfo?(reuben.bmo)
Comment 5•11 years ago
|
||
(In reply to Reuben Morais [:reuben] from comment #4)
> (In reply to Julien Wajsberg [:julienw] from comment #3)
> > Reuben, I think we need to kill another COW, right? Should we land also your
> > patch in bug 697343 comment 76 to 1.3?
>
> We need to kill several COWs, that's what bug 946294 is about. Not sure how
> feasible it is to land that one on 1.3 though.
To clarify, I'm not sure how feasible it is to land 946294 (and deps) on 1.3. Bug 697343 comment 76 can definitely land on 1.3.
Comment 6•11 years ago
|
||
Reuben: the issue with slice here is that we don't have a real array? How comes it works with a "find" result and not with "name" properties?
Comment 7•11 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #6)
> Reuben: the issue with slice here is that we don't have a real array? How
> comes it works with a "find" result and not with "name" properties?
You mean request.result? That's an entirely different object. In bug 946294 we'll make sure all the arrays in the Contacts interfaces work as expected.
Comment 8•11 years ago
|
||
There's a lot of confusion happening from having two bugs open here - I'll move bug 949197 over to this component & dupe this one to that bug.
Reporter | ||
Comment 9•11 years ago
|
||
(In reply to Cristian Rodriguez (:crdlc) from comment #2)
> I think so because we are working together in the office and AFAIK he had
> installed the build 1.3 generated today
oh no, I have installed m-c Gecko, so maybe that's not happening in 1.3
Flags: needinfo?(jmcf)
Comment 10•11 years ago
|
||
(In reply to Jose M. Cantera from comment #9)
> (In reply to Cristian Rodriguez (:crdlc) from comment #2)
> > I think so because we are working together in the office and AFAIK he had
> > installed the build 1.3 generated today
>
> oh no, I have installed m-c Gecko, so maybe that's not happening in 1.3
Upps my apologies for this, I was wrong
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•