Closed Bug 949469 Opened 11 years ago Closed 11 years ago

Store visits in the Places DataStore for each mozbrowserlocationchange event

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 946778

People

(Reporter: benfrancis, Assigned: daleharvey)

References

Details

Attachments

(1 file, 1 obsolete file)

The system browser should record all URL navigations as visits in the Places DataStore and create a new place and/or icon if necessary. This data will be used by the Rocketbar search app. Putting this in the Browser Chrome component for now but not sure yet where the code will live.
Depends on: 946778
Attached file https://github.com/mozilla-b2g/gaia/pull/14664 (obsolete) (deleted) —
Initial patch which stores a visit on every mozbrowserlocationchange and stores the title on every mozbrowsertitlechange. Currently this only works for anything with the navigation bar (Browser2, e.me apps, homescreen bookmarks etc.) I think we should figure out a way for this to work for installed apps too so that visits to apps can be added to the Places database. That would mean we could use the Places database to rank apps and bookmarks against each other using Frecency and the Rocketbar would only have one source to search instead of two.
Attachment #8347409 - Flags: review?(dale)
Rebasing against master because a rebase of the rocketbar2 branch broke all downstream branches. This depends on bug 946778 so land that first, but can be landed safely independent of the rocketbar2 branch. The rocketbar2 branch can pick it up in the next merge from master.
Attachment #8347409 - Attachment is obsolete: true
Attachment #8347409 - Flags: review?(dale)
Attachment #8347985 - Flags: review?(dale)
Comment on attachment 8347985 [details] https://github.com/mozilla-b2g/gaia/pull/14703 So this is good, the functionality will likely go behind the rocketbar preference and it needs rebased against a slightly different places API, so will steal and follow up, but essentially the same
Attachment #8347985 - Flags: review?(dale) → review+
Assignee: bfrancis → dale
Made more sense to implement this as a single patch
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: