1) Flip the "devtools.styleeditor.source-maps-enabled" pref 2) Visit http://google.com 3) Open the Rule View 4) Links appear as "/:11" "/:8", etc. instead of "inline:11"

Small fix for this. This fix also seemed to trigger a local failure due to an editor loading race condition, that's fixed as well.

Whoops, forgot to remove an event listener.

Here's the real one >.< Try: https://tbpl.mozilla.org/?tree=Try&rev=9ad23a159df6

Comment on attachment 8347884 [details] [diff] [review] Fix inline inspector link and race condition that was causing test failure v3 Review of attachment 8347884 [details] [diff] [review]: ----------------------------------------------------------------- R+ for this, simple enough change. I just have a couple of questions. ::: browser/devtools/styleeditor/StyleEditorUI.jsm @@ +453,5 @@ > + if (selected == editor) { > + self.off("editor-added", onAdd); > + deferred.resolve(editor.summary); > + } > + }); I was at first surprised that you weren't using .once() and arrow function, but realized you need to skip events when they're not for the right editor. Can you confirm? ::: browser/devtools/styleinspector/style-inspector.js @@ +49,3 @@ > > // Chrome stylesheets are not listed in the style editor, so show > // these sheets in the view source window instead. Are chrome stylesheets still listed today? I've never come across them before. In any case, how could this even work before your fix? In cases where rule.href was null/undefined, viewSource(rule.href...) must have been failing, right?

(In reply to Patrick Brosset [:pbrosset] from comment #4) > I was at first surprised that you weren't using .once() and arrow function, > but realized you need to skip events when they're not for the right editor. > Can you confirm? Correct, that's why. > > ::: browser/devtools/styleinspector/style-inspector.js > Are chrome stylesheets still listed today? I've never come across them > before. > In any case, how could this even work before your fix? In cases where > rule.href was null/undefined, viewSource(rule.href...) must have been > failing, right? I don't know, but the code was in here before, so I left it. I do know this code is triggered when your style sheet is an inline element style. I think I regressed something in bug 926014. It might now have worked since then /-: