Closed Bug 950147 Opened 11 years ago Closed 10 years ago

Add new Illustrative Wallpapers for v.1.4

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: padamczyk, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken )

Attachments

(1 file)

      No description provided.
Assignee: nobody → padamczyk
Blocks: 2.0-visual-refresh
No longer blocks: 1.3-visual-refresh
No longer depends on: 930600
Whiteboard: ux-tracking, visual design, jian → ux-tracking, visual design, visual-tracking, bokken
Blocks: 950748
No longer blocks: 2.0-visual-refresh
No longer blocks: 950748
Blocks: 950748
Here is the link to all the wallpapers resized and compressed:
https://mozilla.box.com/s/ue0x8qq76seen8bfi83g
Can you please add these to the builds.

And remove the previous illustrated wallpapers:
+ FXOS_Illus_Blocks.png
+ FXOS_Illus_Blocks@1.5x.png
+ FXOS_Illus_Fox_Nature.png
+ FXOS_Illus_Fox_Nature@1.5x.png
+ FXOS_Illus_Mountains.png
+ FXOS_Illus_Mountains@1.5x.png

The wallpapers are located here: https://github.com/mozilla-b2g/gaia/tree/master/apps/wallpaper/resources/320x480
Assignee: padamczyk → pivanov
Attached file patch for Gaia/master (deleted) —
Hey Patryk,
can you check that PR? Hope that I don't miss something
Attachment #8374341 - Flags: feedback?(padamczyk)
Overall looks good... but I don't see the @F1.5x, @2x @2.25x sizes. We need those added as well.
Thanks!
Flags: needinfo?(pivanov)
Blocks: 971704
No longer blocks: 971704
Thanks Patryk :) I added the rest of the images
Flags: needinfo?(pivanov)
Comment on attachment 8374341 [details]
patch for Gaia/master

Hey Vivien,

one more easy for review bug :)
Attachment #8374341 - Flags: review?(21)
Looks good now, Pavel.
Attachment #8374341 - Flags: feedback?(padamczyk) → feedback+
Comment on attachment 8374341 [details]
patch for Gaia/master

Will it be possible to:
 - Remove the FXOS_Illus_ prefix for all wallpapers as it contains more or less some brand related name and that should not be.
 - Convert all the images to png and run the png_recompress.sh tool that lives in $GAIA/tools/png_recompress.sh in order to reduce the size of those images and remove extra headers.
Attachment #8374341 - Flags: review?(21)
Thanks Vivien :)

Hey Patryk
  1. Can we ramove the prefix?
  2. Can you give me the png versions of the wallpapers?

Thanks in advance :)
Flags: needinfo?(padamczyk)
Below is the link to the updated wallpapers.
https://mozilla.box.com/s/bp3zgg7dlv0s6u4w49su

1. For the sake of a less complex file, I removed "FXOS_Illus_" to just "IS_" I want to have all the wallpapers grouped by type... So we'll remove the prefix to the other ones in a bug coming in the next few days.
2. I already removed the extra headers by running a compressor, it made the files about 30% smaller than the original JPGs. They are about 50% smaller than the PNGs would be. I also adjusted the JPG compression to, there is quality loss but its not visible to most people, to maximize file size reduction.
Flags: needinfo?(padamczyk) → needinfo?(pivanov)
I need Vivien's opinion
Flags: needinfo?(pivanov) → needinfo?(21)
(In reply to Patryk Adamczyk [:patryk] UX from comment #9)
> Below is the link to the updated wallpapers.
> https://mozilla.box.com/s/bp3zgg7dlv0s6u4w49su
> 
> 1. For the sake of a less complex file, I removed "FXOS_Illus_" to just
> "IS_" I want to have all the wallpapers grouped by type... So we'll remove
> the prefix to the other ones in a bug coming in the next few days.
> 2. I already removed the extra headers by running a compressor, it made the
> files about 30% smaller than the original JPGs. They are about 50% smaller
> than the PNGs would be. I also adjusted the JPG compression to, there is
> quality loss but its not visible to most people, to maximize file size
> reduction.

Is the jpg versus png size just a guess or have you actually tried ?
Flags: needinfo?(21)
I tried, and tried various compression methods.
ie. Mountains wallpaper @ 720p for Madia
JPG with a 10/12 compression - 310.9 kb
PNG - 712.2 kb

Now when I ran them through the image compressor (remove headers)
JPG - 255.6 kb (compressed 17.8%)
PNG - 669.4 kb (compressed 6.1%)

JPGs are always going to be smaller when you introduce a lot of colour.
Flags: needinfo?(21)
(In reply to Patryk Adamczyk [:patryk] UX from comment #12)
> I tried, and tried various compression methods.
> ie. Mountains wallpaper @ 720p for Madia
> JPG with a 10/12 compression - 310.9 kb
> PNG - 712.2 kb
> 
> Now when I ran them through the image compressor (remove headers)
> JPG - 255.6 kb (compressed 17.8%)
> PNG - 669.4 kb (compressed 6.1%)
> 
> JPGs are always going to be smaller when you introduce a lot of colour.

Sounds good to me then. Lets do the PR without any reference to FXOS and that's fine to me.
Flags: needinfo?(21)
Flags: needinfo?(pivanov)
Attachment #8374341 - Flags: review?(21)
Flags: needinfo?(pivanov)
Thanks Vivien :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/f9947d4854810b21a25a8bcd5c533efe67e34374
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: