Closed Bug 950201 Opened 11 years ago Closed 11 years ago

Add search suggestions to Bing search plugin

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
27 Branch
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(relnote-firefox 29+)

Status:
VERIFIED FIXED
Milestone:
Firefox 29
Tracking Flags:
Tracking Status
relnote-firefox --- 29+

People

(Reporter: mconnor, Assigned: mconnor)

References

Details

(Keywords: feature)

Attachments

(1 file)

bingMobileSuggestions
(deleted), patch
Margaret
: review+
Details | Diff | Splinter Review
Split off from bug 903084. Waiting on formal clarification from Bing about the correct URL to use, as well as a new API code (different from the form code) to be used for mobile. Once we have that, I'll fix it here.
Attached patch bingMobileSuggestions (deleted) — — Splinter Review
This _should_ be correct, but should be verified (I don't have a Fennec build env)
Attachment #8349738 - Flags: review?(margaret.leibovic)
Comment on attachment 8349738 [details] [diff] [review] bingMobileSuggestions Review of attachment 8349738 [details] [diff] [review]: ----------------------------------------------------------------- I verified this makes bing suggestions appear in the UI. r+ assuming this is the correct url/parameters.
Attachment #8349738 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/23eade41cfcc Happy to take on uplifts if product people think it's worth it
Mike - the thread with Bing is using language I'm not very familiar with. Is Margaret's patch in line with their expectations and are you confident it's within agreement between us and Bing (in terms of expectation, use of our currently-used FORM code, etc etc)? Thanks!
https://hg.mozilla.org/mozilla-central/rev/23eade41cfcc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
testing-note (12/20): Only the default provider is currently used in fennec; not sure which is the penultimate bug to handle multiple providers
Correct - and to be clear, search suggestions should only appear for the default provider if suggestions are available. So if the user has made Bing their default provider, Bing's search suggestions should appear (and not Google's, since they would not be in the default position).
Flags: in-moztrap?(fennec)
Might be worth a relnote.
relnote-firefox: --- → ?
Keywords: feature
Karen, it's actually my patch, based on Bing's confirmation that it's the correct bits to use. We may need to change the API code, but this is functionally correct. I'll continue to follow up and make changes where needed, but this will address the immediately urgent issue.
(In reply to Mike Connor [:mconnor] from comment #9) > Karen, it's actually my patch, based on Bing's confirmation that it's the > correct bits to use. We may need to change the API code, but this is > functionally correct. I'll continue to follow up and make changes where > needed, but this will address the immediately urgent issue. I think Karen was responding to Aaron. To paraphrase, comment 6 is describing it working as intended.
Nightly 29.0a1 (2013-12-26) Galaxy Tab (Android 4.0.3 ) "Would you like to turn on Bing search suggestions " is present. Choosing yes will display the suggestions. Settings this to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
Test cases covering this: https://moztrap.mozilla.org/manage/case/2739/ https://moztrap.mozilla.org/manage/case/2740/ I've modify them to include bing too starting Mobile Firefox 29 (both phone and tablet).
Flags: in-moztrap?(fennec) → in-moztrap+
It would be good to modify the relnote so that it states: "Search suggestions are now available with the Bing search plugin when it is set as the default search engine"
Flags: needinfo?(lsblakk)
Ok, try this: "Bing search suggestions available when set to default"
We settled on using this line and it has posted to the release notes: Search suggestions available via Bing search plugin when set as default search engine
Flags: needinfo?(lsblakk)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: