Closed Bug 950273 Opened 11 years ago Closed 9 years ago

Don't use O(n) search over traces to find matching frames

Categories

(DevTools :: Debugger, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: fitzgen, Unassigned)

References

Details

Instead we should maintain a map of { frame id -> set of trace elements for that frame } as we add and remove traces. This would bring us down to an O(1) search for matching frames.
Now this is just lovely.
Are we sure that the memory overhead is worth it? Is searching janky as it is now?
(In reply to Panos Astithas [:past] from comment #2) > Are we sure that the memory overhead is worth it? Is searching janky as it > is now? The only time I've experienced jank when searching is when deleting a search term in one stroke (Opt + Backspace to delete a whole word on OSX) and having all logs be made visible again at once. Unrelated to this, as this is about the hover-frame-matching stuff. I haven't experienced any jank yet.
Priority: -- → P3
Blocks: dbg-trace
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.