Seth Fowler [:seth] [:s2h] Assignee
	Description • 11 years ago

The EXIF parser added to imagelib in bug 869723 incorrectly rejects images taken on little-endian cameras due to a misinterpretation of the spec.

In the TIFF header portion of the EXIF data, the string for determining byte order ("MM" or "II") is followed by a fixed byte sequence "\0*". However, in the little endian case, that byte sequence should be "*\0". When originally writing the parser I wrongly interpreted that sequence as being a sequence of bytes instead of one 16-bit value. Section 4.5.2 of the EXIF spec, however, makes clear that it is a single 16-bit value and thus has to be read according to the requested endianness.

	Seth Fowler [:seth] [:s2h] Assignee
	Comment 1 • 11 years ago

The fix is trivial.

Part 2 will contain a test.

	Seth Fowler [:seth] [:s2h] Assignee
	Comment 2 • 11 years ago

Thanks for the quick review, Timothy!

Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a6e310d81ee

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 3 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/7a6e310d81ee

	Timothy Nikkel (:tnikkel)
	Comment 4 • 11 years ago

Should we uplift this? bug 298619, comment 112 reported this issue in (presumably) release.