Closed
Bug 950370
Opened 11 years ago
Closed 11 years ago
Build fails on Windows - KeyError: u'TestExampleProxyInterface' with --disable-tests
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: balah_v, Assigned: gps)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20100101 Firefox/25.0 (Beta/Release)
Build ID: 20131112160018
Steps to reproduce:
Build xulrunner
Actual results:
28:01.32 Traceback (most recent call last):
28:01.32 File "d:\mozilla-sdk\mozilla-central\build\pymake\pymake\process.py", line 397, in run
28:01.32 rv = m.__dict__[self.method](self.argv)
28:01.32 File "d:\mozilla-sdk\mozilla-central\python\mozbuild\mozbuild\action\webidl.py", line 13, in main
28:01.33 manager.generate_build_files()
28:01.33 File "d:\mozilla-sdk\mozilla-central\dom\bindings\mozwebidlcodegen\__init__.py", line 287, in generate_build_files
28:01.33 written = self.generate_example_files(interface)
28:01.33 File "d:\mozilla-sdk\mozilla-central\dom\bindings\mozwebidlcodegen\__init__.py", line 308, in generate_example_files
28:01.33 root = CGExampleRoot(self.config, interface)
28:01.33 File "d:\mozilla-sdk\mozilla-central\dom\bindings\Codegen.py", line 10314, in __init__
28:01.33 descriptor = config.getDescriptor(interfaceName, False)
28:01.33 File "d:\mozilla-sdk\mozilla-central\dom\bindings\Configuration.py", line 176, in getDescriptor
28:01.33 for d in self.descriptorsByName[interfaceName]:
28:01.33 KeyError: u'TestExampleProxyInterface'
28:01.33 d:\mozilla-sdk\mozilla-central\obj-xul-win-rlz-2\dom\bindings\Makefile:71:0: command 'mozbuild.action.webidl main d:/mozilla-sdk/mozilla-cent
ral/dom/bindings' failed, return code -127
Comment 1•11 years ago
|
||
What does your mozconfig look like?
Comment 2•11 years ago
|
||
Probably like the one when you search for "cat .mozconfig" in https://tbpl.mozilla.org/php/getParsedLog.php?id=31983334&full=1&branch=mozilla-central since automation's broken too.
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Build fails on Windows - KeyError: u'TestExampleProxyInterface' → XULRunner Build fails on Windows - KeyError: u'TestExampleProxyInterface'
Version: unspecified → Trunk
Comment 3•11 years ago
|
||
This looks similar to my issue in bug 950410 I am attaching my .mozconfig
Comment 4•11 years ago
|
||
Here is my .mozconfig
. $topsrcdir/browser/config/mozconfig
BUILD_OFFICIAL=1
export BUILD_OFFICIAL
WIN32_REDIST_DIR=~/mozilla/redist/x86
export WIN32_REDIST_DIR
#WIN32_CRT_SRC_DIR=~/mozilla/crtsrc
mk_add_options BUILD_OFFICIAL=1
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/fx-obj
mk_add_options RUN_AUTOCONF_LOCALLY=1
mk_add_options AUTOCONF=/usr/local/bin/autoconf-2.13
ac_add_options --enable-optimize=-O2
ac_add_options --disable-debug
ac_add_options --disable-tests
ac_add_options --disable-crashreporter
ac_add_options --enable-metro
ac_add_options --enable-jemalloc
ac_add_options --without-x
mk_add_options MOZ_MAKE_FLAGS="-j3"
Comment 6•11 years ago
|
||
Changing Importance to blocker since my blocker bug was duped here.
Severity: critical → blocker
Comment 7•11 years ago
|
||
I am also removing xulrunner form the summary since Firefox builds fail as well.
Summary: XULRunner Build fails on Windows - KeyError: u'TestExampleProxyInterface' → Build fails on Windows - KeyError: u'TestExampleProxyInterface'
Comment 8•11 years ago
|
||
Also, as I mentioned in bug 950410, not only does the build fail, but the build system seems to fail in an odd manner that it does not fail and exit, but continually loops on the error.
Comment 9•11 years ago
|
||
Also, as mentioned in bug 950410, this is building using MSVC 2010 express.
Comment 10•11 years ago
|
||
This is also likely not to be Windows specific.
Summary: Build fails on Windows - KeyError: u'TestExampleProxyInterface' → Build fails on Windows - KeyError: u'TestExampleProxyInterface' with --disable-tests
Comment 11•11 years ago
|
||
This appears to be Windows only disable-tests only. At least my Android and Linux builds do NOT have this issue. Since I have verified that enabling tests results in successful builds, I am reverting my importance upgrade.
Severity: blocker → critical
Comment 12•11 years ago
|
||
Not only on windows. I do not get a crash, but I got an error log on my archlinux too :
44:06.67 xpcshell
44:06.67 plugin-container
44:22.29 Traceback (most recent call last):
44:22.29 File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
44:22.30 "__main__", fname, loader, pkg_name)
44:22.30 File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
44:22.30 exec code in run_globals
44:22.30 File "/home/fred/logs/fox/src/python/mozbuild/mozbuild/action/webidl.py", line 17, in <module>
44:22.30 sys.exit(main(sys.argv[1:]))
44:22.30 File "/home/fred/logs/fox/src/python/mozbuild/mozbuild/action/webidl.py", line 13, in main
44:22.30 manager.generate_build_files()
44:22.30 File "/home/fred/logs/fox/src/dom/bindings/mozwebidlcodegen/__init__.py", line 287, in generate_build_files
44:22.30 written = self.generate_example_files(interface)
44:22.30 File "/home/fred/logs/fox/src/dom/bindings/mozwebidlcodegen/__init__.py", line 308, in generate_example_files
44:22.30 root = CGExampleRoot(self.config, interface)
44:22.30 File "/home/fred/logs/fox/src/dom/bindings/Codegen.py", line 10314, in __init__
44:22.30 descriptor = config.getDescriptor(interfaceName, False)
44:22.30 File "/home/fred/logs/fox/src/dom/bindings/Configuration.py", line 176, in getDescriptor
44:22.30 for d in self.descriptorsByName[interfaceName]:
44:22.30 KeyError: u'TestExampleProxyInterface'
Anyway I get a working Mozilla Firefox after this.
Here is my .mozconfig
mk_add_options PYTHON=/usr/bin/python2
mk_add_options AUTOCONF=autoconf-2.13
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../objdir-fx
ac_add_options --enable-optimize
ac_add_options --with-ccache
ac_add_options --disable-debug
ac_add_options --disable-tests
ac_add_options --disable-crashreporter
ac_add_options --disable-installer
ac_add_options --disable-warnings-as-errors
ac_add_options --disable-debug-symbols
Just to add some informations. And I wonder if bug 950332 is more or less like this one.
Comment 13•11 years ago
|
||
OK you are correct. It seems the bug exists in all architectures, just under Windows the build loops on the error and never completes.
Assignee | ||
Comment 14•11 years ago
|
||
I'm able to reproduce on Linux. Interestingly, make also reported the build as successful - eventually. For whatever reason, I don't think the uncaught exception is being turned into a non-0 exit code. The plot thickens.
Assignee | ||
Comment 15•11 years ago
|
||
Previously, the set of WebIDL example interfaces to build was hardcoded
in the mozwebidlcodegen Python package. Unfortunately, the example
interfaces in that set were dependent on test-only bindings files,
resulting in build failures when tests were disabled (because those
test-only bindings were defined in a test directory).
In this patch, we now declare example interfaces in moz.build files
so the set of example interfaces lives next to the set of defined
bindings files. The example interfaces are defined in a test moz.build
file - in the same file declaring the bindings files that contain the
interfaces - so the example interfaces only get picked up if the
corresponding bindings are defined.
We could probably switch WebIDL moz.build variables to use lists with
flags. That would be good followup fodder. For now, let's fix the build.
https://tbpl.mozilla.org/?tree=Try&rev=840f122d1286
Assignee | ||
Comment 16•11 years ago
|
||
Comment on attachment 8347769 [details] [diff] [review]
webidl.patch
Patch is busted. I thought it worked locally...
Attachment #8347769 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 17•11 years ago
|
||
Fixed a typo in emitter.py.
https://tbpl.mozilla.org/?tree=Try&rev=a3bd2f3eaa15
Attachment #8347769 -
Attachment is obsolete: true
Attachment #8347780 -
Flags: review?(mh+mozilla)
Updated•11 years ago
|
Attachment #8347780 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 18•11 years ago
|
||
Flags: in-testsuite-
Comment 19•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•