Closed
Bug 950904
Opened 11 years ago
Closed 11 years ago
Add telemetry probes for screen dimensions and/or aspect ratio
Categories
(Firefox for Metro Graveyard :: General, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 29
People
(Reporter: sfoster, Assigned: sfoster)
References
Details
(Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff29)
Attachments
(1 file)
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
To inform v2 UI plans and improvements, it would be useful to understand what screen sizes people typically use Firefox for Metro in. Although we support rotation and landscape/portrait mode, given that split view exists the actual window dimensions and ratio are more useful.
The aspect ratio is easily calculated given the dimensions, but if its turns out reporting will be easier with a separate value, we should do that too.
Updated•11 years ago
|
Blocks: metrov1backlog
Whiteboard: [triage]
Updated•11 years ago
|
Whiteboard: [triage] → [triage] [defect] p=0
Updated•11 years ago
|
Whiteboard: [triage] [defect] p=0 → [defect] p=0
Updated•11 years ago
|
Whiteboard: [defect] p=0 → [defect] p=1
Updated•11 years ago
|
Priority: -- → P3
Updated•11 years ago
|
Whiteboard: [defect] p=1 → [feature] p=1
Assignee | ||
Comment 2•11 years ago
|
||
Similar to bug 683071, though we'll need metro-specific data.
Assignee | ||
Comment 3•11 years ago
|
||
Using the UITelemetry module to report window width and height (via ContentAreaObserver), plus test to reassure myself it actually works (it does).
This approach means we'll get whatever width/height values happen to be in play at the time the TelemetryPing comes around. That's a bit arbitrary, but seems as good as any other strategy? We could also listen for resize and update a value but you would get the same end result.
We haven't discussed a plan for how we'll organize and consume this UI telemetry data. With this patch I'm proposing that this is simple measures data, in the UITelemetry.metro-ui "namespace". (vs. individual WINDOW_WIDTH/WINDOW_HEIGHT histograms)
Attachment #8368964 -
Flags: review?(jmathies)
Comment 4•11 years ago
|
||
(In reply to Sam Foster [:sfoster] from comment #3)
> Created attachment 8368964 [details] [diff] [review]
> Add UITelemetry probe to capture window width & height
>
> Using the UITelemetry module to report window width and height (via
> ContentAreaObserver), plus test to reassure myself it actually works (it
> does).
>
> This approach means we'll get whatever width/height values happen to be in
> play at the time the TelemetryPing comes around. That's a bit arbitrary, but
> seems as good as any other strategy? We could also listen for resize and
> update a value but you would get the same end result.
I like the randomness of it.
>
> We haven't discussed a plan for how we'll organize and consume this UI
> telemetry data. With this patch I'm proposing that this is simple measures
> data, in the UITelemetry.metro-ui "namespace". (vs. individual
> WINDOW_WIDTH/WINDOW_HEIGHT histograms)
Should we add orientation to this? Maybe that's in another bug.
Updated•11 years ago
|
Attachment #8368964 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/b6cc3c35d419
jimm: My understand is that reporting is done via map/reduce, so we should be able to pull orientation out of the height/width data we log here. It doesn't tell is if the tablet has been rotated vs. portrait-mode via split screen, but from a UI point of view, we mostly care about landscape (width > height), vs portrait (height > width).
Updated•11 years ago
|
Target Milestone: --- → Firefox 30
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
correcting target milestone, sorry for the bugmail spam
Target Milestone: Firefox 30 → Firefox 29
Updated•11 years ago
|
Whiteboard: [feature] p=1 → p=1 r=ff29
Updated•11 years ago
|
Priority: P3 → P2
QA Contact: jbecerra
Whiteboard: p=1 r=ff29 → p=1 s=it-30c-29a-28b.1 r=ff29
Comment 8•11 years ago
|
||
Could anyone please give guidance in order for the QA to verify this?
Flags: needinfo?(sfoster)
Assignee | ||
Comment 9•11 years ago
|
||
In about:telemetry, under the Simple Measures you should see something like "metro-ui": {"window-width":1600,"window-height":900} under the UITelemetry property.
Flags: needinfo?(sfoster)
Comment 10•11 years ago
|
||
Went through the following verification process with the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-23-03-02-04-mozilla-central/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-23-00-40-01-mozilla-aurora/
Following Sam's instructions from comment #9, I installed and started fxmetro in full view and other variations of snapped view. Made sure that the correct telemetry data was correctly being displayed.
Telemetry data on the X1 Carbon: (appeared correctly on both Nightly/Aurora)
- "metro-ui": {"window-width":1600,"window-height":900}
- "metro-ui": {"window-width":1078,"window-height":900}
- "metro-ui": {"window-width":963,"window-height":900}
- "metro-ui": {"window-width":789,"window-height":900}
Telemetry data on the Surface Pro 2: (appeared correctly on both Nightly/Aurora)
- "metro-ui": {"window-width":1376,"window-height":774}
- "metro-ui": {"window-width":853,"window-height":774}
- "metro-ui": {"window-width":677,"window-height":774}
- "metro-ui": {"window-width":502,"window-height":774}
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•