Closed
Bug 950931
Opened 11 years ago
Closed 11 years ago
Re-enable js/src/jit-test/tests/v8-v5/check-raytrace.js on GGC
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: terrence, Assigned: jonco)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
This is or is very shortly going to be disabled by Brian so that he can land threading assertions for off-main-thread IonBuilder.
|
Assignee | |
Comment 1•11 years ago
|
||
I've tried re-enabling this testcase and the one in bug 950932, but I haven't been able to make them fail, even at the revision where they were originally disabled.
Are there any special options needed that cause this to fail? I've tried all the ones I can think of.
Flags: needinfo?(bhackett1024)
|
||
Comment 2•11 years ago
|
||
These might have only been crashing on tinderbox machines.
Flags: needinfo?(bhackett1024)
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Brian Hackett (:bhackett) (Vacation until early February) from comment #2)
The tests pass on try runs too. At this point I think we should probably just re-enable the tests and keep an eye out for any failures.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Patch to re-enable these tests.
Assignee: general → jcoppeard
Attachment #8367442 -
Flags: review?(terrence)
|
Reporter | |
Comment 5•11 years ago
|
||
Comment on attachment 8367442 [details] [diff] [review]
reenable-disabled-jit-tests
Review of attachment 8367442 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for investigating! r=me
Attachment #8367442 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•