* Description: This problem happened on v1.3 build. While FxOS is playing RTSP streaming the you try to tap "<" icon to go to previous page, the video app will crash. Attach the following document, - Video (WP_20131217_001.mp4) - log & Crash Report (RTSP_Crash_Log_20131217.tar.gz) * Reproduction steps: 1. Launch the following web page via browser - http://goo.gl/lE2eE3 2. Tap the "Video test page" 3. After FxOS launches the video to play RTSP stream, please wait for 20 seconds. 4. Tap "<" icon to go to previous page * Expected result: FxOS goes to previous page without getting any problem * Actual result: A crash happened. * Reproduction build: V1.3 (Buri) - Gaia: 37142f72c422120401dbc90e1f5e8f689576bb8e - Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/cc2ab73484b2 - BuildID 20131215004003 - Version 28.0a2

William, I can't extract your attachment. $ tar zxvf RTSP_Crash_Log_20131217.tar.gz tar: This does not look like a tar archive tar: Skipping to next header tar: Exiting with failure status due to previous errors

Hi, Ethan, Thanks for the reminder. You can use following command to extract it. => gzip -dc RTSP_Crash_Log_20131217.tar.gz | tar -zxf - I also upload a zip (RTSP_Crash_Event_20131217.zip) version. FYI.

I think Ethan is working on this. :)

NI Sri for confirming blocking decision (per some recent email from Sri/Chris - video streaming is not a blocker for 1.3)

** Crash Point ** The crash happens here: http://dxr.mozilla.org/mozilla-central/source/content/media/RtspMediaResource.cpp?from=RtspMediaResource.cpp#536 Program received signal SIGSEGV, Segmentation fault. 0x40ebda3c in mozilla::RtspMediaResource::OnDisconnected (this=0x440e0500, aTrackIdx=0 '\000', aReason=2152398860) at /home/ethan/workspace/hg/mozilla-central/content/media/RtspMediaResource.cpp:536 536 mDecoder->NetworkError(); (gdb) bt #0 0x40ebda3c in mozilla::RtspMediaResource::OnDisconnected (this=0x440e0500, aTrackIdx=0 '\000', aReason=2152398860) at /home/ethan/workspace/hg/mozilla-central/content/media/RtspMediaResource.cpp:536 (gdb) p mDecoder Cannot access memory at address 0x440e0508 ** Root Cause and Solution ** RtspMediaResource (inherited BaseMediaResource) holds a raw pointer to mDecoder. This segmentation fault happens when mDecoder is already shutdown and destroyed by media element but RtspMediaResource still tries to use it. We should set mDecoder as null pointer in RtspMediaResource::Close() and add checks for mDecoder wherever needed.

GDB log when the crash happened.

This patch fixes the problem that RTSP video app might crash after playing for a period of time and closing the app.

Hi Steve, this is another small fix for rtsp crash. Could you help to review it?

Update the comment.

The result of try server: https://tbpl.mozilla.org/?tree=Try&rev=fb0455e3b222

Hi Steve, thanks for your review.

RTSP video is not a blocker for 1.3

Nominated to 1.3+ for this is important bug fixing. Hi Sri, Some RTSP functions were already landed in 1.3 per BD purpose. Is there any concern to uplift related bug fixing?

Thanks for your help! Verified it. I cannot reproduce this bug. * Verificetion build: - Gaia 1f029aa4c924d6c59fd7e8c6d9786a7370755d49 - Gecko http://hg.mozilla.org/releases/mozilla-aurora/rev/c42fd6b6d1fc - BuildID 20140112004002 - Version 28.0a2

(In reply to William Hsu [:whsu] from comment #19) > Verified it. I cannot reproduce this bug. Great to hear that! William, thanks for your work. We need your help to make RTSP feature more and more robust. :)

You're welcome! Due to your hard working, the FxOS RTSP feature became more robust than before! Thanks!