Closed Bug 951443 Opened 11 years ago Closed 11 years ago

CGContext warnings with empty clip

Categories

(Core :: Graphics, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch early exit if clip is empty (obsolete) (deleted) — Splinter Review
When using the BasicCompositor, CG prints many warnings complaining about null contexts. These contexts come from the UnboundnessFixer which tries to create a CGLayer with 0x0 size.
Attachment #8349085 - Flags: review?(jmuizelaar)
As an aside can you look into why were hitting the UnboundnessFixer with BasicCompositor? That suggests badness.
Comment on attachment 8349085 [details] [diff] [review] early exit if clip is empty Review of attachment 8349085 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/DrawTargetCG.cpp @@ +247,5 @@ > { > if (!IsOperatorBoundByMask(blend)) { > mClipBounds = CGContextGetClipBoundingBox(baseCg); > + if (CGRectIsEmpty(mClipBounds)) { > + return nullptr; I think we can just do return baseCG; here and not have to add all of the other checks.
Attachment #8349085 - Flags: review?(jmuizelaar) → review-
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1) > As an aside can you look into why were hitting the UnboundnessFixer with > BasicCompositor? That suggests badness. The DrawSurface call at http://hg.mozilla.org/mozilla-central/annotate/1ad9af3a2ab8/gfx/layers/RotatedBuffer.cpp#l150 passes has aOperator == OP_SOURCE from http://hg.mozilla.org/mozilla-central/annotate/1ad9af3a2ab8/gfx/layers/client/ContentClient.cpp#l652 .
Attached patch no early exit (deleted) — Splinter Review
Great idea.
Attachment #8349085 - Attachment is obsolete: true
Attachment #8356731 - Flags: review?(jmuizelaar)
Attachment #8356731 - Flags: review?(jmuizelaar) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: