Closed
Bug 951443
Opened 11 years ago
Closed 11 years ago
CGContext warnings with empty clip
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mstange, Assigned: mstange)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
When using the BasicCompositor, CG prints many warnings complaining about null contexts. These contexts come from the UnboundnessFixer which tries to create a CGLayer with 0x0 size.
Attachment #8349085 -
Flags: review?(jmuizelaar)
Comment 1•11 years ago
|
||
As an aside can you look into why were hitting the UnboundnessFixer with BasicCompositor? That suggests badness.
Comment 2•11 years ago
|
||
Comment on attachment 8349085 [details] [diff] [review]
early exit if clip is empty
Review of attachment 8349085 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/DrawTargetCG.cpp
@@ +247,5 @@
> {
> if (!IsOperatorBoundByMask(blend)) {
> mClipBounds = CGContextGetClipBoundingBox(baseCg);
> + if (CGRectIsEmpty(mClipBounds)) {
> + return nullptr;
I think we can just do return baseCG; here and not have to add all of the other checks.
Attachment #8349085 -
Flags: review?(jmuizelaar) → review-
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> As an aside can you look into why were hitting the UnboundnessFixer with
> BasicCompositor? That suggests badness.
The DrawSurface call at http://hg.mozilla.org/mozilla-central/annotate/1ad9af3a2ab8/gfx/layers/RotatedBuffer.cpp#l150 passes has aOperator == OP_SOURCE from http://hg.mozilla.org/mozilla-central/annotate/1ad9af3a2ab8/gfx/layers/client/ContentClient.cpp#l652 .
Assignee | ||
Comment 4•11 years ago
|
||
Great idea.
Attachment #8349085 -
Attachment is obsolete: true
Attachment #8356731 -
Flags: review?(jmuizelaar)
Updated•11 years ago
|
Attachment #8356731 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•