The test_peerConnection* tests in dom/media/test/mochitest currently do not verify that ICE was able to connect successfully as part of the tests. As an ICE connection is prerequisite for a MediaStream the IceConnectionState should be checked as part of these tests.

Interdiff link (it's hard to get this out of the system since the old patch was on another bug): https://bugzilla.mozilla.org/attachment.cgi?oldid=8349053&action=interdiff&newid=8350367&headers=1

Comment on attachment 8350367 [details] [diff] [review] adding_ice_connection_checks_for_peerconnection_test.patch Review of attachment 8350367 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Once tiny nit in the comments, but otherwise is ready to go. ::: dom/media/tests/mochitest/pc.js @@ +975,5 @@ > */ > var self = this; > // This enables tests to validate that the next ice state is the one they expect to happen > this.next_ice_state = ""; // in most cases, the next state will be "checking", but in some tests "closed" > + // This allows register their own callbacks for ICE connection state changes s/allows register/allows tests to register/

Comment on attachment 8350367 [details] [diff] [review] adding_ice_connection_checks_for_peerconnection_test.patch Review of attachment 8350367 [details] [diff] [review]: ----------------------------------------------------------------- Sorry, missed this tiny spelling issue the first time. ::: dom/media/tests/mochitest/pc.js @@ +975,5 @@ > */ > var self = this; > // This enables tests to validate that the next ice state is the one they expect to happen > this.next_ice_state = ""; // in most cases, the next state will be "checking", but in some tests "closed" > + // This allows register their own callbacks for ICE connection state changes s/allows register/allows tests to register/ @@ +1371,5 @@ > + * > + * @param {function} onSuccess > + * Callback if ICE connection status is "connected". > + * @param {function} onFailure > + * Callback if ICE connection reaches a different state then s/then/than/

Fixed the spelling errors Adam pointed out.

Comment on attachment 8350777 [details] [diff] [review] adding_ice_connection_checks_for_peerconnection_test.patch https://hg.mozilla.org/integration/mozilla-inbound/rev/fc7cd53d9dd1