Closed
Bug 951999
Opened 11 years ago
Closed 11 years ago
[B2G][DSDS] Need to add SIM id into the WAP Push message.
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kchang, Assigned: bevis)
References
Details
Attachments
(2 files)
(deleted),
patch
|
airpingu
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
airpingu
:
review+
|
Details | Diff | Splinter Review |
For DSDS, Gaia needs to know which SIM the WAP push message comes from. We need to add SIM card information into the system message which convey WAP push.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → btseng
Assignee | ||
Comment 1•11 years ago
|
||
Hi Gene, This patch is to expose the serviceId in the RadioInterfaceLayer to the decoded wap-push message for the further usage of WapPush App. (Verified in both unagi/fugu. The serviceId(zero-based) was exposed correctly to wappush.js in gaia/apps/wappush.) Thanks for your time for reviewing it.
Attachment #8351170 -
Flags: review?(gene.lian)
Updated•11 years ago
|
Attachment #8351170 -
Flags: review?(gene.lian) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Update try server result as followed: https://tbpl.mozilla.org/?tree=Try&rev=202569b1540d
Keywords: checkin-needed
Blocks: 928775
Service ID should be used to get imsi from corresponding SIM[1], or I can fix it in bug 928775 after this bug landed. [1] http://mxr.mozilla.org/mozilla-central/source/dom/wappush/src/gonk/WapPushManager.js#114
Assignee | ||
Comment 4•11 years ago
|
||
[checkin-needed removed] Hi Chuck, Thanks for reminding of getting the correct imsi in WapPushManager in DSDS projects. Since the patch was not landed yet, I'll fix it together with this bug. :) Regards, Bevis Tseng (In reply to Chuck Lee [:chucklee] from comment #3) > Service ID should be used to get imsi from corresponding SIM[1], or I can > fix it in bug 928775 after this bug landed. > > > [1] > http://mxr.mozilla.org/mozilla-central/source/dom/wappush/src/gonk/ > WapPushManager.js#114
Keywords: checkin-needed
Assignee | ||
Comment 5•11 years ago
|
||
This patch is to fix the problem mentioned in comment#3 to get the imsi for WAP CP Message with selected service ID.
Attachment #8355120 -
Flags: review?(gene.lian)
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/30521d0cc862
Flags: in-testsuite?
Comment 7•11 years ago
|
||
Gah, didn't realize you removed checkin-needed. Let me know if it needs to be backed out.
Comment 9•11 years ago
|
||
Backed out for real-looking Gaia integration test failures. https://hg.mozilla.org/integration/b2g-inbound/rev/ff5542c15922 https://tbpl.mozilla.org/php/getParsedLog.php?id=32517700&tree=B2g-Inbound
Whiteboard: [leave open]
Comment 10•11 years ago
|
||
Actually, that probably isn't related. Oh well, sorry for the churn.
Updated•11 years ago
|
Attachment #8355120 -
Flags: review?(gene.lian) → review+
Assignee | ||
Comment 11•11 years ago
|
||
Try server result is green: https://tbpl.mozilla.org/?tree=Try&rev=61e9d58899bc
Keywords: checkin-needed
Comment 12•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/d4ba6886b24e https://hg.mozilla.org/integration/b2g-inbound/rev/d734db94a905
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d4ba6886b24e https://hg.mozilla.org/mozilla-central/rev/d734db94a905
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•