Closed
Bug 952109
Opened 11 years ago
Closed 11 years ago
[message] Subject. The banner informing the user that the maximum length of subject has been reached obscures the subject text field
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed)
People
(Reporter: maat, Assigned: borjasalguero)
References
Details
Attachments
(2 files)
When there is multiple lines of text in the message body the permanent banner informing the user that the maximum length of subject has been reached obscures the subject text field. This means that the user cannot see and therefore refer to what they have typed. refer to screenshot Ooops that will be a design mistake by me. I would suggest as a quick win that we make the message temporary instead of permanent and only generate it when the user tries to add a character that takes the subject over its limit.
Reporter | ||
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
Comment 1•11 years ago
|
||
(note that this is another proof that we should not have merged the subject feature that late in the 1.3 cycle) I don't know how easy it is, I'd need Fernando to comment, but he's away now. So we'll investigate in January.
Reporter | ||
Comment 2•11 years ago
|
||
ni? to Fernando referencing comment 1
Flags: needinfo?(fernando.campo)
Updated•11 years ago
|
Assignee: nobody → borja.bugzilla
Updated•11 years ago
|
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
Comment 4•11 years ago
|
||
(In reply to ayman maat :maat from comment #0) > > I would suggest as a quick win that we make the message temporary instead of > permanent and only generate it when the user tries to add a character that > takes the subject over its limit. Indeed this would be the best option, as leaving less space to the message wouldn't look nice (and means more reflows). I think it does already shows only when the user tries to pass the limit, need to check
Flags: needinfo?(fernando.campo)
Assignee | ||
Comment 5•11 years ago
|
||
Im gonna deliver the patch following Ayman & Fernando's suggestions. With the new patch, the banner is only shown when we 'type', not when we 'focus' in the subject field. On the other hand, we will show the banner for 2/3 seconds.
Assignee | ||
Updated•11 years ago
|
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Assignee | ||
Updated•11 years ago
|
Attachment #8359282 -
Flags: review?(schung)
Comment 7•11 years ago
|
||
Comment on attachment 8359282 [details]
Pull request
Hi Borja, I've left some comments on github. Feel free to ping me once you reply/fix the suggestions, thanks.
Attachment #8359282 -
Flags: review?(schung)
Comment 8•11 years ago
|
||
Comment on attachment 8359282 [details]
Pull request
De-assigning myself as rwaldron and steve are already taking a look, should be enought with them :p
Attachment #8359282 -
Flags: review?(fernando.campo)
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 8359282 [details]
Pull request
Steve, changes addressed! r?
Attachment #8359282 -
Flags: review?(schung)
Comment 10•11 years ago
|
||
Comment on attachment 8359282 [details]
Pull request
Only some small suggestions and we're almost ready :)
Attachment #8359282 -
Flags: review?(schung)
Assignee | ||
Comment 11•11 years ago
|
||
Comment on attachment 8359282 [details]
Pull request
Suggestion addressed! r?
Attachment #8359282 -
Flags: review?(schung)
Comment 12•11 years ago
|
||
(In reply to Borja Salguero [:borjasalguero] from comment #11) > Comment on attachment 8359282 [details] > Pull request > > Suggestion addressed! r? I still feel having another naming would be better because we have banner for 4 different messages with timeout. how about subjectLengthNotice?
Comment 15•11 years ago
|
||
Comment on attachment 8359282 [details]
Pull request
I think the patch is ready but it seems we got some conflict here... :( I'll r+ once you fix the conflict!
Attachment #8359282 -
Flags: review?(schung)
Assignee | ||
Updated•11 years ago
|
Attachment #8359282 -
Flags: review?(schung)
Comment 17•11 years ago
|
||
Comment on attachment 8359282 [details]
Pull request
r=me, thanks for the fixing!
Attachment #8359282 -
Flags: review?(schung) → review+
Assignee | ||
Comment 18•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/d8f015f8ce8c70b59f939c6b03304dc39c28c809 https://github.com/borjasalguero/gaia/commit/8d20961eaa4c63a7daea9069dad69015e2905266 R+. Merged.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-b2g-v1.3:
--- → affected
Comment 19•11 years ago
|
||
Uplifted d8f015f8ce8c70b59f939c6b03304dc39c28c809 to: v1.3: a3e62d005b072c4050a2ec0e0331fad647c07833
Updated•11 years ago
|
Blocks: feature-mms-subject
Comment 20•11 years ago
|
||
FYI I filed bug 968714 because I think the behavior implemented here is not completely right.
Updated•11 years ago
|
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•