Closed
Bug 952120
Opened 11 years ago
Closed 11 years ago
Port bug 774572 (Define JAR_MANIFESTS in moz.build files) to DOMi, Chatzilla, Venkman
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla29
People
(Reporter: philip.chee, Assigned: philip.chee)
References
()
Details
Attachments
(3 files, 2 obsolete files)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
STR: have the required moz.build files containing: +JAR_MANIFESTS += ['jar.mn'] But I still cannot build DOM Inspector. Error message: mozmake[3]: Entering directory 'c:/t1/hg/objdir-sm/mozilla/extensions/inspector/resources/locale' c:/t1/hg/comm-central/mozilla/config/rules.mk:1327: *** c:/t1/hg/comm-central/mozilla/extensions/inspector/resources/locale contains a jar.mn file but this file is not declared in a JAR_MANIFESTS variable in a moz.build file. Stop. I *do* have a moz.build file in that directory with the requisite declarations.
Attachment #8350087 -
Flags: feedback?(gps)
![]() |
Assignee | |
Updated•11 years ago
|
![]() |
Assignee | |
Comment 1•11 years ago
|
||
Finally managed to get DOM Inspector, Chatzilla, and Venkman to build. I don't know if this is the right way of doing things but at least it works.
Attachment #8350087 -
Attachment is obsolete: true
Attachment #8350087 -
Flags: feedback?(gps)
Attachment #8350194 -
Flags: review?(gps)
![]() |
Assignee | |
Updated•11 years ago
|
Summary: When building SeaMonkey, cannot build DOM Inspector even with JAR manifests defined in moz.build (same for Chatzilla → Port bug 774572 (Define JAR_MANIFESTS in moz.build files) to DOMi, Chatzilla, Venkman
Comment 2•11 years ago
|
||
Comment on attachment 8350194 [details] [diff] [review] V1.0 Working patch for DOM Inspector Review of attachment 8350194 [details] [diff] [review]: ----------------------------------------------------------------- The DOM inspector extension build config is... special. resources/Makefile.in is iterating over some pre-defined languages and calling |make -C locale AB_CD=$locale|. resources/locale isn't known to moz.build, so it isn't part of regular directory traversal. Thus, JAR_MANIFESTS in moz.build don't come into play. I think marking resources/Makefile.in as an external make file and dealing with the underlying problem later is sufficient. ::: resources/locale/moz.build @@ +2,5 @@ > +# This Source Code Form is subject to the terms of the Mozilla Public > +# License, v. 2.0. If a copy of the MPL was not distributed with this > +# file, You can obtain one at http://mozilla.org/MPL/2.0/. > + > +JAR_MANIFESTS += ['jar.mn'] You shouldn't need this after marking resources/locale/Makefile.in as externally managed. ::: resources/moz.build @@ +6,5 @@ > CONFIGURE_SUBST_FILES += ['locale/Makefile'] > > +DIRS += [ > + 'locale', > +] Or this.
Attachment #8350194 -
Flags: review?(gps)
![]() |
Assignee | |
Updated•11 years ago
|
Attachment #8350194 -
Attachment filename: file_952120.txt → Bug952120DOMiV1.patch
Attachment #8350194 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #2) > ::: resources/locale/moz.build > @@ +2,5 @@ >> +# This Source Code Form is subject to the terms of the Mozilla Public >> +# License, v. 2.0. If a copy of the MPL was not distributed with this >> +# file, You can obtain one at http://mozilla.org/MPL/2.0/. >> + >> +JAR_MANIFESTS += ['jar.mn'] > > You shouldn't need this after marking resources/locale/Makefile.in as > externally managed. Fixed. > ::: resources/moz.build > @@ +6,5 @@ >> CONFIGURE_SUBST_FILES += ['locale/Makefile'] >> >> +DIRS += [ >> + 'locale', >> +] > > Or this. Fixed.
Updated•11 years ago
|
Attachment #8350597 -
Flags: review?(gps) → review+
Updated•11 years ago
|
Attachment #8350598 -
Flags: review?(gps) → review+
Updated•11 years ago
|
Attachment #8350599 -
Flags: review?(gps) → review+
Comment 6•11 years ago
|
||
Pushed all patches: http://hg.mozilla.org/dom-inspector/rev/ea97f73f8302 http://hg.mozilla.org/venkman/rev/7f29ecb94e07 http://hg.mozilla.org/chatzilla/rev/d565df1a6c92
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Blocks: DOMi2.0.15
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•