Closed
Bug 952302
Opened 11 years ago
Closed 11 years ago
[Messages] We need to load the gesture detector mock from SMS or shared
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: julienw, Assigned: julienw)
References
Details
Attachments
(1 file)
When running the unit tests in B2G-Desktop, we see the gesture detector mock is not loaded.
This happens because we load it from the system app, which is a different hostname and therefore is blocked by the CSP.
Therefore we need to either copy this mock locally or move it to shared.
|
||
Comment 1•11 years ago
|
||
Interesting! Is this caused by some change to the CSP used in b2g?
|
Assignee | |
Comment 2•11 years ago
|
||
I actually don't know if that ever worked in b2g because to CSP ;)
That said they changed the implementation of CSP and as a result some things that incorrectly worked before don't know (see bug 929172 for the whole story)
Depends on: 929172
|
|
Assignee | |
Comment 3•11 years ago
|
||
Waiting for a Travis run before asking review.
Assignee: nobody → felash
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8363504 [details]
github PR
Green Travis, and no more failing sms test in the "unit tests in b2g" job in https://travis-ci.org/mozilla-b2g/gaia/jobs/17279119 !
r? from Étienne for the system part and Rick for the sms part.
(Étienne: this is very small :) )
Attachment #8363504 -
Flags: review?(waldron.rick)
Attachment #8363504 -
Flags: review?(etienne)
|
||
Updated•11 years ago
|
Attachment #8363504 -
Flags: review?(etienne) → review+
|
|
||
Updated•11 years ago
|
Attachment #8363504 -
Flags: review?(waldron.rick) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
master: 1b5ba1e7ab4e3abb3446975c9f90961d773217fa
thanks !
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•