Closed
Bug 952330
Opened 11 years ago
Closed 11 years ago
Synchronize updates to global object slots
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Some global object dynamically allocated reserved slots are read from off thread during IonBuilder (e.g. builtin class constructors), so the global object's slots need to be protected by the compilation lock. Bug 785905 made a note of this but I forgot to actually add the synchronization code.
Attachment #8350391 -
Flags: review?(jdemooij)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8350391 [details] [diff] [review]
patch
Review of attachment 8350391 [details] [diff] [review]:
-----------------------------------------------------------------
Good find..
Attachment #8350391 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/4c45705d14c4 for apparently introducing ggc permaorange: https://tbpl.mozilla.org/php/getParsedLog.php?id=32292679&tree=Mozilla-Inbound
Looks like the same error in rootanalysis: https://tbpl.mozilla.org/php/getParsedLog.php?id=32294137&tree=Mozilla-Inbound
Relanded in http://hg.mozilla.org/integration/mozilla-inbound/rev/5a1833435382 because it was really bug 951213 that caused the bustage.
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•