Closed
Bug 952473
Opened 11 years ago
Closed 11 years ago
SessionStore should only watch for top-level pageshow events
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox27 fixed, firefox28 fixed, firefox29 fixed)
RESOLVED
FIXED
Firefox 29
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(1 file)
(deleted),
patch
|
wesj
:
review+
bajaj
:
approval-mozilla-aurora+
bajaj
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Desktop and Metro both limit the pagshow event to top-level windows/documents. We used to when we created the session store code Metro now uses. We lost it in the port.
I noticed this because SessionStore.onTabLoad was showing up in cnn.com pageload profiles.
Attachment #8350615 -
Flags: review?(wjohnston)
Updated•11 years ago
|
Attachment #8350615 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 1•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8350615 [details] [diff] [review]
Top-level pageshow only v0.1
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Reduces the amount of times session is saved during a pageload. It should only happen once, but without this patch it can happen for iframes too.
User impact if declined: Just a possible performance issue.
Testing completed (on m-c, etc.): It's been on m-c for a while
Risk to taking this patch (and alternatives if risky): Low risk
String or IDL/UUID changes made by this patch: None
Attachment #8350615 -
Flags: approval-mozilla-beta?
Attachment #8350615 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #8350615 -
Flags: approval-mozilla-beta?
Attachment #8350615 -
Flags: approval-mozilla-beta+
Attachment #8350615 -
Flags: approval-mozilla-aurora?
Attachment #8350615 -
Flags: approval-mozilla-aurora+
Comment 4•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a990d28d924e
https://hg.mozilla.org/releases/mozilla-beta/rev/a4ceb800b3dc
Assignee: nobody → mark.finkle
status-firefox27:
--- → fixed
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•