Closed
Bug 952533
Opened 11 years ago
Closed 11 years ago
[Messages] The contact lookup fails in some situation
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(b2g-v1.3 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.3 | --- | fixed |
People
(Reporter: julienw, Assigned: julienw)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
rwaldron
:
review+
fabrice
:
approval-gaia-v1.3+
|
Details |
STR:
* add a contact containing only a given name (eg: Julien) and a phone number
* launch the SMS app
* start a new message
* lookup "julien aaa"
Expected:
* No result
Actual:
* "Julien" is left over from the previous search
Assignee | ||
Comment 1•11 years ago
|
||
* Bail out early if the current contact does not have the wanted field
---
apps/sms/js/contacts.js | 5 +++++
apps/sms/test/unit/contacts_test.js | 13 ++++++++++++-
2 files changed, 17 insertions(+), 1 deletion(-)
Attachment #8350679 -
Flags: review?(waldron.rick)
Comment 2•11 years ago
|
||
What conditions cause contact records to have missing fields?
Comment 3•11 years ago
|
||
Comment on attachment 8350679 [details]
github PR
r=me, but I'm still curious about my previous question :)
Attachment #8350679 -
Flags: review?(waldron.rick) → review+
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Rick Waldron [:rwaldron] from comment #2)
> What conditions cause contact records to have missing fields?
This is the first step of my STR ;) Just add a record with missing fields.
I think this comes from the WebIDL change: before this change, the mozContacts API was using default values (eg: empty arrays) for missing fields, but now the missing fields are null.
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8350679 [details]
github PR
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 850430 (probably)
[User impact] if declined: see comment 0
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none
Attachment #8350679 -
Flags: approval-gaia-v1.3?(fabrice)
Updated•11 years ago
|
Attachment #8350679 -
Flags: approval-gaia-v1.3?(fabrice) → approval-gaia-v1.3+
Assignee | ||
Comment 8•11 years ago
|
||
Hey John, can you please assist with the uplift ?
Thanks !
blocking-b2g: 1.3? → ---
Flags: needinfo?(jhford)
Comment 9•11 years ago
|
||
[v1.3 2289663] Bug 952533 - [Messages] The contact lookup fails in some situation r=rwaldron
status-b2g-v1.3:
--- → fixed
Flags: needinfo?(jhford)
You need to log in
before you can comment on or make changes to this bug.
Description
•