Closed
Bug 952817
Opened 11 years ago
Closed 11 years ago
VariablesView.createHierarchy should always be called when the view is emptied
Categories
(DevTools :: Object Inspector, defect, P2)
DevTools
Object Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bbenvie
:
review+
|
Details | Diff | Splinter Review |
There are no other realistic scenarios of this method being useful apart from when clearing the variables view. I think it should also be private, to avoid having clients need to think about it specifically.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 3•11 years ago
|
||
Making this a P2 because it block another bug which blocks a bunch of other bugs.
Priority: P3 → P2
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8350980 [details] [diff] [review] v1 Review of attachment 8350980 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay, Christmas! This is all straightforward, LGTM.
Attachment #8350980 -
Flags: review?(bbenvie) → review+
|
|
||
Updated•11 years ago
|
Flags: needinfo?(bbenvie)
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/641671b50e97
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/641671b50e97
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•