Closed
Bug 952905
Opened 11 years ago
Closed 11 years ago
"Move to Menu" and "Menu Bar" share access key
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 29
People
(Reporter: jkitch, Assigned: jkitch)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [Australis:P4][good first verify])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Right click on the toolbar or tab area.
"Menu Bar" and "Move to Menu" have the same access key (M)
Is this desirable?
Other similar menu items (open link, close tab and view page source/info) manage to have unique access keys
|
Assignee | |
Updated•11 years ago
|
Blocks: australis-merge
|
||
Updated•11 years ago
|
Blocks: australis-cust
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
|
|
||
Comment 2•11 years ago
|
||
Egh, actually, I should have read better. This is a separate issue. Dolske? (NB: there won't be a "Menu bar" entry on OS X, but it'll conflict on Windows and Linux...)
Status: RESOLVED → REOPENED
Flags: needinfo?(dolske)
Resolution: DUPLICATE → ---
|
||
Updated•11 years ago
|
Status: REOPENED → NEW
Whiteboard: [Australis:P4]
|
||
Comment 3•11 years ago
|
||
Oh, nuts. I guess the simple fix would be to just change the accesskey to "o" for "Move to Menu" and "Move to Toolbar". (Not sure if that needs an entity change for L10N?)
Flags: needinfo?(dolske)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Changed according to comment 3.
I've added a localisation note warning as the problem also affects es-CL and pt-PT. Do they need follow up bugs?
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8356430 [details] [diff] [review]
move.diff
(In reply to James Kitchener (:jkitch) from comment #4)
> I've added a localisation note warning as the problem also affects es-CL and
> pt-PT. Do they need follow up bugs?
Yes, please file bugs for them: https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Localizations
Attachment #8356430 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 6•11 years ago
|
||
Land this one instead.
Localisation note now also warns of the potential for clashes with personalbarCmd (Bookmark toolbar), which occurs in the 'it' locale.
Attachment #8356430 -
Attachment is obsolete: true
|
||
Comment 7•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [Australis:P4] → [Australis:P4][fixed-in-fx-team]
|
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][fixed-in-fx-team] → [Australis:P4]
Target Milestone: --- → Firefox 29
|
||
Updated•11 years ago
|
Whiteboard: [Australis:P4] → [Australis:P4][good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•