Closed
Bug 953408
Opened 11 years ago
Closed 9 years ago
Unprefix -moz-hyphens
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: sjw+bugzilla, Assigned: jtd)
References
(Blocks 3 open bugs)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
Gecko has a very well working hyphenation and this part of the spec looks stable enough. So we should remove the prefix.
Comment 1•11 years ago
|
||
Does the last call issues list for the spec look like it's not going to lead to hyphenation-related changes?
Updated•11 years ago
|
Keywords: dev-doc-needed
Last hyphenation-related changes were from 1 September 2011 to 19 January 2012: http://www.w3.org/TR/2012/WD-css3-text-20120119/#recent-changes
Firefox supports the current spec.
There are no hyphenation-related bugs or testcases:
http://www.w3.org/Style/CSS/Tracker/products/10
http://test.csswg.org/suites/css3-text/nightly-unstable/html/chapter-6.htm
Updated•11 years ago
|
Severity: normal → enhancement
Component: Layout: Text → CSS Parsing and Computation
Updated•11 years ago
|
Blocks: css-text-3
Assignee | ||
Comment 3•9 years ago
|
||
Unprefix the -moz-hyphens property and add a temporary alias for -moz-hyphens ==> hyphens. Conversions of existing tests done in a separate patch.
Attachment #8660523 -
Flags: review?(cam)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jdaggett
Assignee | ||
Comment 4•9 years ago
|
||
Switch tests to use unprefixed hyphens property
Attachment #8660524 -
Flags: review?(jfkthame)
Assignee | ||
Comment 5•9 years ago
|
||
This property and it's property value definitions have been stable for a while and implemented in prefixed form across IE/Webkit/Gecko for some time. Only Chrome lacks support for this.
Our implementation includes support for a wide set of languages and I don't see any significant bug logged against hyphenation currently. I think we should do the unprefixing for the FF43 release.
Assignee | ||
Comment 6•9 years ago
|
||
Fix up minor omission in property_database.js, need to include alias explicitly.
Attachment #8660523 -
Attachment is obsolete: true
Attachment #8660523 -
Flags: review?(cam)
Attachment #8660552 -
Flags: review?(cam)
Assignee | ||
Comment 7•9 years ago
|
||
CSS3 Text description of 'hyphens':
http://www.w3.org/TR/css-text-3/#hyphenation
MDN page:
https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens
Comment 8•9 years ago
|
||
(In reply to John Daggett (:jtd) from comment #5)
> This property and it's property value definitions have been stable for a
> while and implemented in prefixed form across IE/Webkit/Gecko for some time.
> Only Chrome lacks support for this.
>
> Our implementation includes support for a wide set of languages and I don't
> see any significant bug logged against hyphenation currently. I think we
> should do the unprefixing for the FF43 release.
Given all this, and that there have still been no changes to css-text-3 about hyphenation since the Last Call, and there are no open issues on it, I think it's safe to unprefix.
Can you send an Intent to Ship mail to dev-platform about this? https://wiki.mozilla.org/WebAPI/ExposureGuidelines is geared towards DOM APIs, but we tend to use it for CSS features too (e.g. see Mats' display:contents Intent to Ship mail from a few months ago, for example). I don't expect anyone to have problems with this. I suggest mentioning in the mail that you plan to enable this at the end of this week, just to give people a few days to respond.
Updated•9 years ago
|
Attachment #8660552 -
Flags: review?(cam) → review+
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #8)
> Can you send an Intent to Ship mail to dev-platform about this?
> https://wiki.mozilla.org/WebAPI/ExposureGuidelines is geared towards DOM
> APIs, but we tend to use it for CSS features too (e.g. see Mats'
> display:contents Intent to Ship mail from a few months ago, for example). I
> don't expect anyone to have problems with this. I suggest mentioning in the
> mail that you plan to enable this at the end of this week, just to give
> people a few days to respond.
Yes, planning to do exactly this sometime this week!
Updated•9 years ago
|
Attachment #8660524 -
Flags: review?(jfkthame) → review+
Comment 10•9 years ago
|
||
Assignee | ||
Comment 11•9 years ago
|
||
Intent to unprefix message:
https://lists.w3.org/Archives/Public/www-style/2015Sep/0115.html
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f3994cb9aa50
https://hg.mozilla.org/mozilla-central/rev/583b3c9b6e0e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment 13•9 years ago
|
||
Added the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/hyphens-property-has-been-unprefixed/
Keywords: site-compat
Reporter | ||
Comment 14•9 years ago
|
||
Thanks for fixing! I just updated the docs:
https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens
https://developer.mozilla.org/en-US/Firefox/Releases/43
Keywords: dev-doc-needed → dev-doc-complete
Reporter | ||
Comment 15•9 years ago
|
||
Is it already to late for a relnote?
Release Note Request (optional, but appreciated)
[Why is this notable]:
Notable change for WebDevs
[Suggested wording]:
Support for unprefixed 'hyphens' property
[Links (documentation, blog post, etc)]:
https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens
relnote-firefox:
--- → ?
I just added it, thanks!
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•