Closed Bug 9542 Opened 25 years ago Closed 24 years ago

Esc key does not dismiss dialogs

Categories

(Core :: XUL, defect, P3)

x86
All
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: cpratt, Assigned: bryner)

References

Details

(Keywords: helpwanted, platform-parity, Whiteboard: nsbeta3-)

Build ID: 1999070908 Platform: Windows NT 4, Red Hat Linux 6 (Mac OS apprunner cannot generate dialogs in this build) To reproduce: - Launch apprunner - Select File | Opoen - Press the Esc key Result: Nothing happens. Expected result: The dialog is dismissed (functionally equivalent to clicking the Cancel button).
Assignee: joki → trudelle
Component: Event Handling → XP Toolkit/Widgets
This has got to be an apprunner thing of some sort unless the event is unable to reach the dialog.
Assignee: trudelle → sdagley
Target Milestone: M9
reassigning to sdagley as p3 for m9, a companion task to handling default buttons in dialogs.
Status: NEW → ASSIGNED
Chris, It isn't clear to me if this is a complaint about the behavior of the the platform native file selection dialogs (since the Mac wasn't presenting these briefly) or that the current intermediate dialog that appears when selecting File|Open doesn't recognize the escape key. I'd stop by your cube and ask but it's kinda late and most sensible people have already gone home for the evening.
The current intermediate dialog (the that appears when File | Open is selected does not recognize the Esc key. Using the 1999071218 build under the Mac OS, that dialog box never comes up, so I can't say for sure if this is a problem on the Mac OS as well. The problem exists with all dialogs; for example, selecting Edit | Preferences and pressing Esc should cancel the Preferences dialog, but nothing happens.
Depends on: 9635
Doh!, I misread the build # and thought the Mac problem was something I had fixed last week. I was wrong. The intermediate dialog isn't coming up on the Mac because there's apparently no widget in focus when the menu event is dispatched. Accodring to saari this is a bug in the focus manager and should be referred to joki. As for the dialogs not dismissing on 'Esc', that stays with me as a dependency on bug/feature 9635.
Got it. This problem also happens on the Mac OS (thanks, sdagley, for explaining why I couldn't get a dialog to come up) using the 1999071218 build.
Depends on: 9673
No longer depends on: 9635
Target Milestone: M9 → M10
Oops, forgot to move this to M10 when I moved 9635
Blocks: 12673
Whiteboard: requires completion of 9673
Target Milestone: M10 → M11
[1999091409] works for todays build on Win98, WinNT, and MacPPC Does not work on Linux
mass-moving most m11 bugs to m12
Mass-moving non-PDT+ bugs to M13
Assignee: sdagley → hangas
Status: ASSIGNED → NEW
No longer depends on: 9673
Whiteboard: requires completion of 9673
I think this was supposed to go to hangas with 9635. Reassinging to hangas for comment and probably closing as FIXED. Note that the file dialogs are platform native so if they don't support a keystroke shortcut by default it is not clear that not emulating the behavior of some other platform should be considered a bug.
This is still not working on my Mac build from 12-17-99. The xul has the Enter and Esc keys wired up but Esc still does not cancel the dialogs. Enter/Return are working fine now, but Esc does nothing but hide the cursor (in the two dialogs I tested). Since this is not working it should not be my bug. Is the idea for me to go find an owner for this one?
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Marking fixed. This is working now. Possibly Hyatt's checkins since Friday afternoon.
Still not working on Linux : 2000-07-13-08-M17 (Note that this feature *does* work on linux using Nav 4.x, and also with several other linux programs I tried it on) reopening for linux only. Verified 2000-07-13-09-M17 : WinNT & Win98 2000-07-13-08-M17 : Mac
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Keywords: correctness
Target Milestone: M13 → M18
I think this is dup of bug 32223
*** Bug 32223 has been marked as a duplicate of this bug. ***
I can take this one.
Assignee: hangas → bryner
Status: ASSIGNED → NEW
Nominating for beta3. The fix is trivial and we need this for cross-platform parity.
Status: NEW → ASSIGNED
Keywords: nsbeta3, pp
over to jrgm...
QA Contact: janc → jrgm
nsbeta3-, but would take safe patch.
Keywords: helpwanted
Whiteboard: nsbeta3-
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.