Closed Bug 954342 Opened 11 years ago Closed 11 years ago

Prepend # automatically to IRC channel names if no prefix was specified

Categories

(Chat Core :: IRC, enhancement)

Product:
Chat Core
Component:
IRC
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

Patch v2
(deleted), patch
clokep
: review+
Details | Diff | Splinter Review
*** Original post on bio 909 at 2011-07-10 18:14:00 UTC *** We just discussed this on IRC: http://log.bezut.info/instantbird/110710/#m205
Blocks: 953944
Summary: Prepend # automatically to channel names if no prefix was specified → Prepend # automatically to IRC channel names if no prefix was specified
No longer blocks: 953944
Depends on: 953944
*** Original post on bio 909 at 2012-02-27 15:37:55 UTC *** Moving IRC bugs to new IRC component.
Component: General → IRC
Attached patch Patch (obsolete) (deleted) — — Splinter Review
*** Original post on bio 909 as attmnt 2247 at 2013-02-28 14:41:00 UTC *** This is the patch just discussed on IRC. Completely untested.
Attachment #8354011 - Flags: review?(clokep)
Assignee: nobody → florian
Comment on attachment 8354011 [details] [diff] [review] Patch *** Original change on bio 909 attmnt 2247 at 2013-02-28 14:47:23 UTC *** I'd like a comment above this saying that we're assuming # if the prefix the user wanted if they don't include one (maybe for parity of broken behavior of other clients).
Attachment #8354011 - Flags: review?(clokep) → review-
Attached patch Patch v2 (deleted) — — Splinter Review
*** Original post on bio 909 as attmnt 2248 at 2013-02-28 22:33:00 UTC *** This time I tested it! :-)
Attachment #8354012 - Flags: review?(clokep)
Comment on attachment 8354011 [details] [diff] [review] Patch *** Original change on bio 909 attmnt 2247 at 2013-02-28 22:33:50 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354011 - Attachment is obsolete: true
Comment on attachment 8354012 [details] [diff] [review] Patch v2 *** Original change on bio 909 attmnt 2248 at 2013-02-28 22:55:08 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354012 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 909 at 2013-02-28 23:45:26 UTC *** Committed as http://hg.instantbird.org/instantbird/rev/67181cd06826
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: