Closed
Bug 954952
Opened 11 years ago
Closed 11 years ago
Make autojoin and "Join Chat" handle excess whitespace better
Categories
(Chat Core :: General, defect)
Chat Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.2
People
(Reporter: aleth, Assigned: aleth)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1520 at 2012-06-18 20:20:00 UTC ***
*** Due to BzAPI limitations, the initial description is in comment 1 ***
|
Assignee | |
Comment 1•11 years ago
|
||
*** Original post on bio 1520 as attmnt 1629 at 2012-06-18 20:20:00 UTC ***
Matches the /join syntax in bug 953828 (bio 385).
Attachment #8353386 -
Flags: review?(clokep)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8353386 [details] [diff] [review]
Patch
*** Original change on bio 1520 attmnt 1629 at 2012-06-19 01:42:36 UTC ***
Looks good. :)
Attachment #8353386 -
Flags: review?(clokep) → review+
|
|
||
Updated•11 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
No longer depends on: 953828
Whiteboard: [checkin-needed]
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [checkin-needed]
|
|
Assignee | |
Comment 3•11 years ago
|
||
*** Original post on bio 1520 as attmnt 1631 at 2012-06-19 10:34:00 UTC ***
Also prevents autojoins and the join Chat dialog from calling joinChat with a parameter that contains nothing but whitespace.
Attachment #8353388 -
Flags: review?(clokep)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8353386 [details] [diff] [review]
Patch
*** Original change on bio 1520 attmnt 1629 at 2012-06-19 10:34:38 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353386 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Summary: Tolerate whitespace after commas in the autojoin parameter → Make autojoin and "Join Chat" handle excess whitespace better
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8353388 [details] [diff] [review]
Patch
*** Original change on bio 1520 attmnt 1631 at 2012-06-20 00:56:49 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8353388 -
Flags: review?(clokep) → review+
|
|
||
Updated•11 years ago
|
Whiteboard: [checkin-needed]
|
|
||
Comment 6•11 years ago
|
||
*** Original post on bio 1520 at 2012-06-21 00:31:41 UTC ***
Checked in as http://hg.instantbird.org/instantbird/rev/aab2aae54619
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•