Closed Bug 955458 Opened 11 years ago Closed 11 years ago

Add method to get all contacts from ContactsService

Categories

(Chat Core :: General, defect)

Product:
Chat Core
Component:
General
Platform:
x86
Other
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

Attachments

(1 file, 2 obsolete files)

Change UUID
(deleted), patch
florian
: review+
Details | Diff | Splinter Review
*** Original post on bio 2021 at 2013-06-27 22:15:00 UTC *** Currently anything that wants to get all contacts has to obtain all tags from the tag service, iterate through them, get contacts for each tag, check for duplicates (contacts can have multiple tags), and so on, leading to complicated code. The idea is to add a method to the ContactsService to return an array of all contacts to eliminate this hindrance.
Attached patch Add getContacts method (obsolete) (deleted) — — Splinter Review
*** Original post on bio 2021 as attmnt 2524 at 2013-06-27 22:19:00 UTC *** This adds the required method.
Attachment #8354292 - Flags: review?(benediktp)
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Attached patch Fix a typo (obsolete) (deleted) — — Splinter Review
*** Original post on bio 2021 as attmnt 2525 at 2013-06-27 22:21:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354293 - Flags: review?(benediktp)
Comment on attachment 8354292 [details] [diff] [review] Add getContacts method *** Original change on bio 2021 attmnt 2524 at 2013-06-27 22:21:33 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354292 - Attachment is obsolete: true
Attachment #8354292 - Flags: review?(benediktp)
Comment on attachment 8354293 [details] [diff] [review] Fix a typo *** Original change on bio 2021 attmnt 2525 at 2013-06-27 22:27:55 UTC *** I can't test this but the changes look good.
Attachment #8354293 - Flags: review?(benediktp) → review+
Whiteboard: [checkin-needed]
*** Original post on bio 2021 at 2013-06-27 22:52:56 UTC *** Comment on attachment 8354293 [details] [diff] [review] (bio-attmnt 2525) Fix a typo > [scriptable, uuid(f1619b49-310b-47aa-ab1c-238aba084c62)] Do we need to change the uuid when editing stuff in the interface? I don't mind for Instantbird, but Thunderbird may have a stricter policy.
Attached patch Change UUID (deleted) — — Splinter Review
*** Original post on bio 2021 as attmnt 2526 at 2013-06-27 22:57:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354294 - Flags: review?(florian)
Comment on attachment 8354293 [details] [diff] [review] Fix a typo *** Original change on bio 2021 attmnt 2525 at 2013-06-27 22:57:32 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354293 - Attachment is obsolete: true
Comment on attachment 8354294 [details] [diff] [review] Change UUID *** Original change on bio 2021 attmnt 2526 at 2013-06-27 23:03:31 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354294 - Flags: review?(florian) → review+
*** Original post on bio 2021 at 2013-06-27 23:48:14 UTC *** http://hg.instantbird.org/instantbird/rev/55009d68c4ec Quickly closed bug. :)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: