Closed Bug 955480 Opened 11 years ago Closed 11 years ago

Icon sizes are totally wrong on Windows Aero in awesometab

Categories

(Instantbird Graveyard :: Conversation, defect)

Product:
Instantbird Graveyard
Component:
Conversation
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: clokep, Assigned: nhnt11)

References

Details

Attachments

(3 files)

Picture showing the issue
(deleted), image/png
Details
Add newtab.css to aero in jar.mn
(deleted), patch
clokep
: review+
Details | Diff | Splinter Review
Make sure newtab.css gets preprocessed for aero
(deleted), patch
clokep
: review+
Details | Diff | Splinter Review
*** Original post on bio 2043 at 2013-07-12 10:34:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Blocks: 955452
Attached image Picture showing the issue (deleted) —
*** Original post on bio 2043 as attmnt 2579 at 2013-07-12 10:34:00 UTC *** Take a look at the picture. Florian: "exactly, we forgot the aero newtab.css line in jar.mn"
*** Original post on bio 2043 as attmnt 2584 at 2013-07-12 13:24:00 UTC *** Untested, but I think this should work?
Attachment #8354353 - Flags: review?(clokep)
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Comment on attachment 8354353 [details] [diff] [review] Add newtab.css to aero in jar.mn *** Original change on bio 2043 attmnt 2584 at 2013-07-12 13:28:32 UTC *** Let's give it a try, I can test when I get home though.
Attachment #8354353 - Flags: review?(clokep) → review+
*** Original post on bio 2043 at 2013-07-13 00:32:00 UTC *** http://hg.instantbird.org/instantbird/rev/976c27b24268
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
Status: RESOLVED → VERIFIED
*** Original post on bio 2043 at 2013-07-15 18:02:43 UTC *** Seems that some warnings are being thrown, this file needs to be preprocessed first (it needs the * in front of it).
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
*** Original post on bio 2043 as attmnt 2600 at 2013-07-15 19:37:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354369 - Flags: review?(clokep)
Comment on attachment 8354353 [details] [diff] [review] Add newtab.css to aero in jar.mn *** Original change on bio 2043 attmnt 2584 at 2013-07-15 19:37:53 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354353 - Attachment is obsolete: true
Comment on attachment 8354369 [details] [diff] [review] Make sure newtab.css gets preprocessed for aero *** Original change on bio 2043 attmnt 2600 at 2013-07-15 19:39:56 UTC *** Sorry for missing this the first time.
Attachment #8354369 - Flags: review?(clokep) → review+
Whiteboard: [checkin-needed]
Comment on attachment 8354353 [details] [diff] [review] Add newtab.css to aero in jar.mn *** Original change on bio 2043 attmnt 2584 at 2013-07-15 20:20:36 UTC *** It landed, so let's keep this attachment visible.
Attachment #8354353 - Attachment is obsolete: false
*** Original post on bio 2043 at 2013-07-15 21:27:32 UTC *** http://hg.instantbird.org/instantbird/rev/0a39e989c23b
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: